Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argument Parsing failures should be reported as warnings and not debug messages #571

Closed
ferventcoder opened this issue Jan 22, 2016 · 0 comments
Closed

Argument Parsing failures should be reported as warnings and not debug messages #571

ferventcoder opened this issue Jan 22, 2016 · 0 comments
Assignees
@ferventcoder
Labels
5 - Released Bug Priority_HIGH
Milestone
0.9.10

Comments

@ferventcoder
Copy link
Member

I thought at first there was another issue with choco, until I went looking at the logs and realized it was because I used bundled and unbundled options, but didn't use -- in the version statement (copied from chocolatey.org). There are likely enough folks on 0.9.9+ now that we can change those messages to be appropriate to the latest versions. It should also draw some folks out who need to upgrade.

Parsing -version resulted in exception:
 Cannot bundle unregistered option '-e'.
@ferventcoder ferventcoder self-assigned this Jan 22, 2016
@ferventcoder ferventcoder added this to the 0.9.10 milestone Jan 22, 2016
@ferventcoder ferventcoder changed the title Parsing failures should be reported as warnings and not debug messages Argument Parsing failures should be reported as warnings and not debug messages Jan 22, 2016
ferventcoder added a commit to ferventcoder/choco that referenced this issue Apr 9, 2016
@ferventcoder
(chocolateyGH-571) Arg parsing error should be warning
1140679 
Instead of logging a debug message, argument parsing errors should be
reported as warnings in case the argument doesn't actually evaluate
appropriately later.
ferventcoder added a commit to ferventcoder/choco that referenced this issue Apr 11, 2016
@ferventcoder
Merge branch 'stable'
35ec3ef 
* stable:
  (chocolateyGH-268) Remove Unused Code
  (chocolateyGH-268) Add BeforeModify to install template
  (maint) solution folders for nuspecs / top level
  (maint) catch pack catastrophic errors
  (chocolateyGH-586) Ignore invalid options/switches by default
  (specs) update scenarios
  (chocolateyGH-596) Allow failure on invalid license
  (chocolateyGH-571) Arg parsing error should be warning
  (chocolateyGH-680) Switch to .NET Client Profile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Bug Priority_HIGH
Projects
None yet
Milestone
0.9.10
Development

No branches or pull requests
2 participants
@ferventcoder @gep13