Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage package templates with a specially named package and special package folder #542

Closed
ferventcoder opened this issue Jan 12, 2016 · 15 comments
Closed

Manage package templates with a specially named package and special package folder #542

ferventcoder opened this issue Jan 12, 2016 · 15 comments
Assignees
@ferventcoder
Labels
5 - Released Improvement Priority_LOW Up For Grabs
Milestone
0.9.10

Comments

@ferventcoder
Copy link
Member

Package should be named ".template" - folder name is templates.
@ferventcoder
Copy link
Member Author

Related to #76 and #449.

@ferventcoder ferventcoder changed the title Install a specially named package with a special folder for managing templates Install a specially named package with a special folder for managing package templates Jan 12, 2016
@ferventcoder ferventcoder changed the title Install a specially named package with a special folder for managing package templates Manage package templates with a specially named package and special package folder Jan 12, 2016
@ferventcoder ferventcoder added this to the 0.9.10.x milestone Jan 15, 2016
@ferventcoder ferventcoder modified the milestones: 0.9.10, 0.9.10.x Jan 28, 2016
@ferventcoder ferventcoder self-assigned this Jan 28, 2016
ferventcoder added a commit that referenced this issue Jan 28, 2016
@ferventcoder
(GH-542) Manage Packages Templates as Packages
6c13ca1 
Manage package creation templates through regular choco commands. The
package must have a specially named id ("*.template") and have a
"templates" folder that contains the package template.
@gep13
Copy link
Member

gep13 commented Jan 28, 2016

@ferventcoder is this referring to a Chocolatey Package? If so, which one?

@ferventcoder
Copy link
Member Author

No packages exist for this yet that I know of.

@gep13
Copy link
Member

gep13 commented Jan 28, 2016

@ferventcoder gotcha, the way I read this issue, the default templates were going to ship as a package as well. My bad.

@ferventcoder
Copy link
Member Author

;)

@ferventcoder ferventcoder reopened this Jan 28, 2016
@ferventcoder
Copy link
Member Author

Forgot one little bit - automation scripts under this folder should not be evaluated.

ferventcoder added a commit that referenced this issue Jan 28, 2016
@ferventcoder
(GH-542) Don't Run templated automation scripts
d5f09bf 
Exclude templates folders from the search for the automation scripts.
ferventcoder added a commit that referenced this issue Jan 28, 2016
@ferventcoder
(GH-542) Rename nuspec.template file
7b24a9f 
Unfortunately nuspec can't be saved as nuspecs in a package. So the
name of the nuspec will need to be *.nuspec.template for it to pack up
nicely. Find that file and rename it to .nuspec on install.
ferventcoder added a commit that referenced this issue Jan 28, 2016
@ferventcoder
Merge branch 'stable'
91aab42 
* stable:
  (GH-542) Rename nuspec.template file
  (GH-542) Don't Run templated automation scripts
  (GH-542) Manage Packages Templates as Packages
@ferventcoder
Copy link
Member Author

Okay, there we go.

@ferventcoder
Copy link
Member Author

Gotcha, the way I read this issue, the default templates were going to ship as a package as well. My bad.

It would be great to fix the default template outside of a Chocolatey release, so I give you https://chocolatey.org/packages/default.template.

@gep13
Copy link
Member

gep13 commented Jan 28, 2016

Woo hoo! 👍

@aronovgj
Copy link

That package fails on newest beta
https://gist.github.com/aronovgj/f1829e114f3455bd294f

Or isn't it supposed to be installed?

@ferventcoder
Copy link
Member Author

Did you miss the comment on the package page? It's expected to fail.

@ferventcoder
Copy link
Member Author

@aronovgj see d5f09bf

@aronovgj
Copy link

Thought the validator/verifier were expected to fail...

@ferventcoder
Copy link
Member Author

@aronovgj I just pushed a new beta that should not fail on this. It's still under automated review though. Be sure to check the package page for when it is available.

@aronovgj
Copy link

👍 worked

ferventcoder added a commit to ferventcoder/choco that referenced this issue Apr 9, 2016
@ferventcoder
(chocolateyGH-268) Revert removed fixes
4a9bc73 
- Adding back in chocolateyGH-560 - loading modules from known location (90d53ee)
- Adding back in chocolateyGH-542 - not running templated scripts (d5f09bf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Improvement Priority_LOW Up For Grabs
Projects
None yet
Milestone
0.9.10
Development

No branches or pull requests
3 participants
@ferventcoder @gep13 @aronovgj