Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help should exit zero if called with the help switch, otherwise non-zero on bad commands #473

Closed
ferventcoder opened this issue Oct 28, 2015 · 2 comments
Closed

Help should exit zero if called with the help switch, otherwise non-zero on bad commands #473

ferventcoder opened this issue Oct 28, 2015 · 2 comments
Assignees
@ferventcoder
Labels
5 - Released Improvement Up For Grabs
Milestone
0.10.4

Comments

@ferventcoder
Copy link
Member

Also related to #468

Badly passed commands display the help menu and exit with non-zero, but also explicitly calling for help will exit non-zero.
@ferventcoder ferventcoder added this to the 0.9.10 milestone Oct 28, 2015
@ferventcoder ferventcoder changed the title Help command should exit zero if called with the help switch, otherwise non-zero on bad commands Help should exit zero if called with the help switch, otherwise non-zero on bad commands Oct 28, 2015
@ferventcoder ferventcoder modified the milestones: 0.9.10.1, 0.9.10 Jan 30, 2016
@ferventcoder ferventcoder modified the milestones: 0.9.10.1, 0.9.10.2, 0.9.10.3, 0.9.10.4, 0.9.10.5 Jun 17, 2016
@ferventcoder ferventcoder modified the milestones: 0.10.1, 0.10.2 Sep 2, 2016
@ferventcoder ferventcoder modified the milestones: 0.10.2, 0.10.3 Sep 20, 2016
@ferventcoder ferventcoder removed this from the 0.10.2 milestone Sep 20, 2016
@ferventcoder ferventcoder modified the milestones: 0.10.3, 0.10.4 Oct 3, 2016
@Cubix651
Copy link
Contributor

I will try to fix it.

Cubix651 added a commit to Cubix651/choco that referenced this issue Jan 14, 2017
@Cubix651
(chocolateyGH-473) Correct exit code when help is requested
6c6af6f 
There are two cases when choco shows help message: when it is
explicitly requested or when parsing fails. In first scenario
choco should return 0 exit code, in second - non-zero value.
This commit introduces new property UnsuccessfulParsing in
ChocolateyConfiguration and using this property it fixes bug
with incorrect exit code.
@Cubix651 Cubix651 mentioned this issue Jan 15, 2017
Closed
@ferventcoder ferventcoder self-assigned this Jan 15, 2017
ferventcoder pushed a commit that referenced this issue Mar 19, 2017
@Cubix651 @ferventcoder
(GH-473) Correct exit code when help is requested
b47ce15 
There are two cases when choco shows help message: when it is
explicitly requested or when parsing fails. In first scenario
choco should return 0 exit code, in second - non-zero value.
This commit introduces new property UnsuccessfulParsing in
ChocolateyConfiguration and using this property it fixes bug
with incorrect exit code.
ferventcoder added a commit that referenced this issue Mar 19, 2017
@ferventcoder
Merge branch 'pr1137' into stable
68c3b16 
* pr1137:
  (GH-473) Correct exit code when help is requested
ferventcoder added a commit that referenced this issue Mar 19, 2017
@ferventcoder
Merge branch 'stable'
4944318 
* stable:
  (GH-473) Correct exit code when help is requested
@ferventcoder
Copy link
Member Author

This will be released with 0.10.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Improvement Up For Grabs
Projects
None yet
Milestone
0.10.4
Development

No branches or pull requests
3 participants
@ferventcoder @gep13 @Cubix651