Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollback when upgrade fails #47

Closed
ferventcoder opened this issue Feb 1, 2015 · 1 comment
Closed

Rollback when upgrade fails #47

ferventcoder opened this issue Feb 1, 2015 · 1 comment
Assignees
@ferventcoder
Labels
5 - Released CoreTeam Improvement
Milestone
0.9.9

Comments

@ferventcoder
Copy link
Member

When an upgrade fails, it will drag out the entire package folder with the new stuff over to lib-bad. But you still may have the old version installed.

Should the old version be put back?
@ferventcoder ferventcoder self-assigned this Feb 1, 2015
@ferventcoder ferventcoder added this to the 0.9.9 milestone Feb 1, 2015
ferventcoder added a commit that referenced this issue Feb 1, 2015
@ferventcoder
(GH-47) Note the operation is update for upgrade
70a8d13
ferventcoder added a commit that referenced this issue Feb 2, 2015
@ferventcoder
(GH-47) Rollback when upgrade fails
4197b07 
Allow the user to determine if they want the previous package files to
be put back when an upgrade fails or is canceled. Handle state of
install, upgrade or uninstall that may have previous package folder
still around (usually due to unforeseen errors or user ctrl+c during
choco run).
ferventcoder added a commit to ferventcoder/choco that referenced this issue Feb 15, 2015
@ferventcoder
(chocolateyGH-47) Search for directories
c7e408f
ferventcoder added a commit to ferventcoder/choco that referenced this issue Feb 15, 2015
@ferventcoder
(chocolateyGH-47) Rollback enhancements
6c33fa0 
If the primary rollback directory is not found, search for
directories that have the packagename and end with the rollback
suffix.

When moving the rollback to its previous name, ensure that you just
remove the rollback suffix so that the name of the folder is restored
as it was before.
ferventcoder added a commit to ferventcoder/choco that referenced this issue Feb 15, 2015
@ferventcoder
Merge branch 'stable'
410a299 
* stable: (31 commits)
  (specs) Install scenarios
  (specs) integration SetUpFixture
  (log) log actual file ran instead of string[]
  (specs) remove and readd install envvar
  (maint) formatting
  (specs) add more todos
  Set ChocolateyInstall envvar for POSH
  (specs) add simpleinjector as dependency
  (specs) packages for scenarios
  (maint) need system console for debug
  (chocolateyGH-98) Fix upgrade is a dependency of others
  (maint) formatting
  PathResolver - explicit to_string() method
  (maint) formatting
  (maint) formatting
  (chocolateyGH-52) Rename config confirmation setting
  (chocolateyGH-103) Determine if AllowMultiple
  (doc) clarify powershell script options
  XmlService - don't delete on save
  (chocolateyGH-47) Rollback enhancements
  ...
ferventcoder referenced this issue Feb 17, 2015
@ferventcoder
(infra) Refactor backup/rollback
ffd1975 
Backup should move to another directory entirely so that the
PackageManager is not confused about something being installed when it
is a backup. This was found during scenario testing.
@ferventcoder
Copy link
Member Author

Refactored backup/rollback to a completely separate folder to avoid confusing the nuget packagemanager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released CoreTeam Improvement
Projects
None yet
Milestone
0.9.9
Development

No branches or pull requests
2 participants
@ferventcoder @gep13