Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add uninstall PowerShell helper for VSIX (visual studio extension) #389

Open
timabell opened this issue Aug 22, 2015 · 6 comments
Open

Add uninstall PowerShell helper for VSIX (visual studio extension) #389

timabell opened this issue Aug 22, 2015 · 6 comments
Labels
0 - Backlog Improvement Up For Grabs
Milestone
1.x

Comments

@timabell
Copy link

Hi, hope you don't mind me asking here. I'm trying to create a package for a visual studio extension (vsix). I've got the install working; now I am wondering about allowing uninstall, it would be nice if I could provide that but there doesn't seem to provision for it.

I was following the instructions at https://github.com/chocolatey/choco/wiki/HelpersInstallChocolateyVsixPackage but can't find an equivalent uninstall command.

C:\Program Files (x86)\Microsoft Visual Studio 14.0>vsixinstaller /? does show an uninstall switch.

I assume it's just not implemented? Cheers

Thanks for a great tool.
@ferventcoder
Copy link
Member

@timabell You are correct, an uninstall helper just has not been added. If you want to add one, we accept pull requests. Just make sure you read over our Contributing doc prior to ensure you set up commits correctly and can sign the CLA. :)

@timabell
Copy link
Author

Okay thanks for confirming. I'll pass on the PR then as I'm not keen on CLAs.

@ferventcoder
Copy link
Member

No worries.

@ferventcoder ferventcoder added this to the 1.x milestone Aug 23, 2015
@kevindaub
Copy link

I was going to look into this one. At first glance, it looks like the uninstall and install will have very similar code (i.e. like locating VS Install directory).

  • Would creating another function like Get-VisualStudioInstallDir or Get-VisualStudioVersion be okay to add as a helper function as well?
  • Also, are there any powershell unit tests or integration tests that should be included (I see C#, but no powershell)?

@ferventcoder
Copy link
Member

C# integration tests are in for testing different behaviors of packages, installing and uninstalling, but don't actually test making changes to the system itself. I've been thinking about how to introduce those kinds of tests without having to change system state. You are welcome to make suggestions.

All of the PowerShell functions will be reimplemented as C# PowerShell cmdlets at some point, so something else to consider.

@kevindaub
Copy link

I'd prefer to keep in C#, so maybe that's the path I'll go down. It also allows easier testing.

ferventcoder added a commit that referenced this issue May 18, 2017
@ferventcoder
(GH-389) API - Ensure ChocolateyInstall env var
3323a5a 
When running Chocolatey, it is helpful to ensure environment variables
are set correctly. Sometimes ChocolateyInstall location will not have
been determined correctly or be waiting on a reboot/explorer.exe
restart prior to applications realizing that the value has changed.
Ensure that even with that, the value for ChocolateyInstall is
determined correctly.
ferventcoder added a commit to ferventcoder/choco that referenced this issue May 18, 2017
@ferventcoder
Merge branch 'stable'
52837e2 
* stable:
  Remove duplicate word
  (chocolateyGH-1285) Default push to new or old w/warning
  (chocolateyGH-1285) Add old/new default push source
  (chocolateyGH-1298) GenericRunner.count() sets security protocol
  (chocolateyGH-1298) GenericRunner.list() should match run()
  (maint) API - Warn on extraction errors
  (chocolateyGH-389) API - Ensure ChocolateyInstall env var
  (maint) Do not load config back into global
  (chocolateyGH-1296) API - Reuse existing base configuration
  (maint) API - Note methods that won't allow changes
  (chocolateyGH-1294) API - Expose container directly
  (build) option to build debug version
  (doc) Source/Key notes surrounding source/apikey
  (maint) log that license file has been found
  (chocolateyGH-1287) Non-internal SimpleInjector XML Comments
  (maint) formatting
  (chocolateyGH-1287) API - Ensure dll can work w/licensed code
  (chocolateyGH-1284) Install-ChocolateyPackage aliases File/File64
@pauby pauby changed the title uninstall command for vsix (visual studio extension) Add uninstall PowerShell helper for VSIX (visual studio extension) Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - Backlog Improvement Up For Grabs
Projects
None yet
Milestone
1.x
Development

No branches or pull requests
4 participants
@timabell @ferventcoder @mwrock @kevindaub