Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to create an MSI on non-tagged builds #3465

Open
2 tasks done
corbob opened this issue Jun 13, 2024 · 0 comments · May be fixed by #3466
Open
2 tasks done

Add the ability to create an MSI on non-tagged builds #3465

corbob opened this issue Jun 13, 2024 · 0 comments · May be fixed by #3466
Assignees
@corbob
Labels
3 - Review BuildAutomation

Comments

@corbob
Copy link
Member

corbob commented Jun 13, 2024

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

No response

Describe The Solution. Why is it needed?

When working on the MSI, currently you need to tag your commit so that the Chocolatey.Cake.Recipe will generate the MSI. It would be beneficial to have the MSI be able to be built without a git tag.

Additional Context

No response

Related Issues

No response
corbob added a commit to corbob/choco that referenced this issue Jun 13, 2024
@corbob
(chocolatey#3465) Don't build MSI unless asked
0dfbf69 
Changed the logic for skipping an MSI build to skip it by default, and
no longer depend on a tagged build. This will allow developers to
generate an MSI by adding `--shouldBuildMsi=true`.
corbob added a commit to corbob/choco that referenced this issue Jun 13, 2024
@corbob
(chocolatey#3465) Build MSI on CI Builds
03d0af0 
When running the builds in CI, we should generate the MSI as well. This
will allow us to get an MSI for any build to test with if needed.
corbob added a commit to corbob/choco that referenced this issue Jun 13, 2024
@corbob
(chocolatey#3465) Build MSI on GHA
af5b8a4 
As with the previous commit, this adds the configuration for GitHub
Actions. Thus allowing us to ensure the MSI is able to be built in
GitHub Actions as well.

When running the builds in CI, we should generate the MSI as well. This
will allow us to get an MSI for any build to test with if needed.
@corbob corbob self-assigned this Jun 13, 2024
@corbob corbob linked a pull request Jun 13, 2024 that will close this issue
Open
10 tasks
corbob added a commit to corbob/choco that referenced this issue Jun 13, 2024
@corbob
(chocolatey#3465) Don't build MSI unless asked
4006b58 
Changed the logic for skipping an MSI build to skip it by default, and
no longer depend on a tagged build. This will allow developers to
generate an MSI by adding `--shouldBuildMsi=true`.
corbob added a commit to corbob/choco that referenced this issue Jun 13, 2024
@corbob
(chocolatey#3465) Build MSI on CI Builds
ca742dc 
When running the builds in CI, we should generate the MSI as well. This
will allow us to get an MSI for any build to test with if needed.
corbob added a commit to corbob/choco that referenced this issue Jun 13, 2024
@corbob
(chocolatey#3465) Build MSI on GHA
8c9dbed 
As with the previous commit, this adds the configuration for GitHub
Actions. Thus allowing us to ensure the MSI is able to be built in
GitHub Actions as well.

When running the builds in CI, we should generate the MSI as well. This
will allow us to get an MSI for any build to test with if needed.
corbob added a commit to corbob/choco that referenced this issue Jun 13, 2024
@corbob
(chocolatey#3465) Build MSI on GHA
c8151ad 
As with the previous commit, this adds the configuration for GitHub
Actions. Thus allowing us to ensure the MSI is able to be built in
GitHub Actions as well.

When running the builds in CI, we should generate the MSI as well. This
will allow us to get an MSI for any build to test with if needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corbob corbob

Labels
3 - Review BuildAutomation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(#3465) Allow building an MSI during outside of tagged commits. corbob/choco
1 participant
@corbob