Ensure Install-ChocolateyPath adds a new entry to the PATH when part of it is already there

[knappmk]

Checklist

• I have verified this is the correct repository for opening this issue.
• I have verified no other issues exist related to my problem.
• I have verified this is not an issue for a specific package.
• I have verified this issue is not security related.
• I confirm I am using official, and not unofficial, or modified, Chocolatey products.

What You Are Seeing?

I create my own internal Chocolatey packages. In the install script I have to use the command Install-ChocolateyPath. Thereby I want to have multiple folders of a program added to the PATH environment variable (here: "C:\tools\msys2\usr\bin" and "C:\tools\msys2"). But if "C:\tools\msys2\usr\bin" is already present in the PATH variable and "C:\tools\msys2" is not present (e.g. during an upgrade), then Install-ChocolateyPath does not add the path anymore.
It is not an environment update problem, because no change has taken place in the registry and the output of the command confirms this (see log). The cause of the error is in the condition that checks whether the path already exists in the PATH variable or not.

choco/src/chocolatey.resources/helpers/functions/Install-ChocolateyPath.ps1

Line 83 in 48ee5cf

if (!$envPath.ToLower().Contains($pathToInstall.ToLower())) {

What is Expected?

The path should be taken over into the PATH variable, even if a subpath of this path already exists in the variable. For this, it should be checked exactly whether the path is already included in the variable or not.

How Did You Get This To Happen?

1. Pick a path (e.g. "C:\tools\msys2") and a subpath (e.g. "C:\tools\msys2\usr\bin").
2. Make sure that a subpath of the path to be added already exists in the PATH variable (e.g. 'C:\tools\msys2\usr\bin')
3. Call the command Install-ChocolateyPath "C:\tools\msys64\" -pathType "Machine".
4. Check the PATH environment variable: the path should not have been added

System Details

• Operating System: Windows 10.0.17763.0
• Windows PowerShell version: 5.1.17763.4720
• Chocolatey CLI Version: 1.3.0
• Chocolatey Licensed Extension version: None
• Chocolatey License type: Free
• Terminal/Emulator: Windows PowerShell

Installed Packages

N/A

Output Log

Sorry no Chocolatey log here, as I have already narrowed down the problem and don't want to post any internal issues. Running the command does not show any output - normally it should say "PATH environment variable does not have C:\tools\msys64 in it. Adding..."

14:53 C:\Users\Administrator.VH12052\Desktop> $env:PATH
C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\WINDOWS\System32\OpenSSH\;C:\ProgramData\chocolatey\bin;C:\tools\msys64\usr\bin;C:\Progra
m Files\Git\cmd;C:\Program Files\IcedTeaWeb\WebStart\bin;C:\Program Files\OpenJDK\jdk-13\bin;
14:53 C:\Users\Administrator.VH12052\Desktop> Install-ChocolateyPath "C:\tools\msys64" -pathType Machine
14:53 C:\Users\Administrator.VH12052\Desktop> $env:PATH
C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\WINDOWS\System32\OpenSSH\;C:\ProgramData\chocolatey\bin;C:\tools\msys64\usr\bin;C:\Progra
m Files\Git\cmd;C:\Program Files\IcedTeaWeb\WebStart\bin;C:\Program Files\OpenJDK\jdk-13\bin;

Additional Context

I add a pull request that should fix the problem by matching the exact path to be added.

[choco-bot]

🎉 This issue has been resolved in version 2.3.0 🎉

The release is available on:

• GitHub Release
• Chocolatey Package

Your GitReleaseManager bot 📦 🚀