Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OS_NAME environment variable to support Windows 11 and Server 2019/2022 #2754

Closed
TheCakeIsNaOH opened this issue Jun 30, 2022 · 1 comment · Fixed by #2755
Closed

Update OS_NAME environment variable to support Windows 11 and Server 2019/2022 #2754

TheCakeIsNaOH opened this issue Jun 30, 2022 · 1 comment · Fixed by #2755
Assignees
@TheCakeIsNaOH
Labels
5 - Released Improvement
Milestone
2.3.0

Comments

@TheCakeIsNaOH
Copy link
Member

Is Your Feature Request Related To A Problem? Please describe.

The OS_NAME environment variable is set to Windows 10 when running on Windows 11. This should be corrected.

Describe The Solution. Why is it needed?

The operating system name should be correct

Additional Context.

The OS name is generated based on the build number here:

choco/src/chocolatey/infrastructure/platforms/Platform.cs

Lines 122 to 148 in d8ca7ba

case "10.0":
name = isServer ? "Windows Server 2016" : "Windows 10";
break;
case "6.4":
name = isServer ? "Windows Server 2016" : "Windows 10";
break;
case "6.3":
name = isServer ? "Windows Server 2012 R2" : "Windows 8.1";
break;
case "6.2":
name = isServer ? "Windows Server 2012" : "Windows 8";
break;
case "6.1":
name = isServer ? "Windows Server 2008 R2" : "Windows 7";
break;
case "6.0":
name = isServer ? "Windows Server 2008" : "Windows Vista";
break;
case "5.2":
name = isServer ? "Windows Server 2003" : "Windows XP";
break;
case "5.1":
name = "Windows XP";
break;
case "5.0":
name = "Windows 2000";
break;

Related Issues

N/A
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jun 30, 2022
@TheCakeIsNaOH
(chocolatey#2754) Add support for detecting newer Windows versions
54b9e14 
This allows Chocolatey CLI to detect Windows 11, Server 2019 and Server 2022.
Which will allow the OS_NAME environment variable to be set correctly on those
operating systems.
@TheCakeIsNaOH TheCakeIsNaOH mentioned this issue Jun 30, 2022
Merged
9 tasks
@TheCakeIsNaOH TheCakeIsNaOH self-assigned this Jul 30, 2022
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Sep 25, 2022
@TheCakeIsNaOH
(chocolatey#2754) Add support for detecting newer Windows versions
fddfb31 
This allows Chocolatey CLI to detect Windows 11, Server 2019 and Server 2022.
Which will allow the OS_NAME environment variable to be set correctly on those
operating systems.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Sep 25, 2022
@TheCakeIsNaOH
(chocolatey#2754) Add support for detecting newer Windows versions
70296c4 
This allows Chocolatey CLI to detect Windows 11, Server 2019 and Server 2022.
Which will allow the OS_NAME environment variable to be set correctly on those
operating systems.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Dec 22, 2022
@TheCakeIsNaOH
(chocolatey#2754) Add support for detecting newer Windows versions
ffb504e 
This allows Chocolatey CLI to detect Windows 11, Server 2019 and Server 2022.
Which will allow the OS_NAME environment variable to be set correctly on those
operating systems.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jan 7, 2023
@TheCakeIsNaOH
(chocolatey#2754) Add support for detecting newer Windows versions
ad4e68f 
This allows Chocolatey CLI to detect Windows 11, Server 2019 and Server 2022.
Which will allow the OS_NAME environment variable to be set correctly on those
operating systems.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jan 13, 2023
@TheCakeIsNaOH
(chocolatey#2754) Add support for detecting newer Windows versions
ec36338 
This allows Chocolatey CLI to detect Windows 11, Server 2019 and Server 2022.
Which will allow the OS_NAME environment variable to be set correctly on those
operating systems.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jun 6, 2023
@TheCakeIsNaOH
(chocolatey#2754) Add support for detecting newer Windows versions
23c32de 
This allows Chocolatey CLI to detect Windows 11, Server 2019 and Server 2022.
Which will allow the OS_NAME environment variable to be set correctly on those
operating systems.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jun 15, 2023
@TheCakeIsNaOH
(chocolatey#2754) Add support for detecting newer Windows versions
298025c 
This allows Chocolatey CLI to detect Windows 11, Server 2019 and Server 2022.
Which will allow the OS_NAME environment variable to be set correctly on those
operating systems.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jul 1, 2023
@TheCakeIsNaOH
(chocolatey#2754) Add support for detecting newer Windows versions
4bb8167 
This allows Chocolatey CLI to detect Windows 11, Server 2019 and Server 2022.
Which will allow the OS_NAME environment variable to be set correctly on those
operating systems.
@gep13 gep13 added this to the 2.3.0 milestone Dec 14, 2023
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Jan 9, 2024
@TheCakeIsNaOH
(chocolatey#2754) Add support for detecting newer Windows versions
a67b3de 
This allows Chocolatey CLI to detect Windows 11, Server 2019 and Server 2022.
Which will allow the OS_NAME environment variable to be set correctly on those
operating systems.
gep13 pushed a commit to TheCakeIsNaOH/choco that referenced this issue Apr 24, 2024
@TheCakeIsNaOH @gep13
(chocolatey#2754) Add support for detecting newer Windows versions
939b4f2 
This allows Chocolatey CLI to detect Windows 11, Server 2019 and Server 2022.
Which will allow the OS_NAME environment variable to be set correctly on those
operating systems.
gep13 added a commit that referenced this issue Apr 24, 2024
@gep13
Merge pull request #2755 from TheCakeIsNaOH/platform-name
03126a9 
(#2754) Add support for detecting newer Windows versions
@pauby pauby changed the title Update OS_NAME to support Windows 11 and Server 2019/2022 Update OS_NAME environment variable to support Windows 11 and Server 2019/2022 May 28, 2024
@choco-bot
Copy link

🎉 This issue has been resolved in version 2.3.0 🎉

The release is available on:

Your GitReleaseManager bot 📦 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheCakeIsNaOH TheCakeIsNaOH

Labels
5 - Released Improvement
Projects
None yet
Milestone
2.3.0
Development

Successfully merging a pull request may close this issue.

(#2754) Add support for detecting newer Windows versions TheCakeIsNaOH/choco
3 participants
@gep13 @choco-bot @TheCakeIsNaOH