-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uninstaller service should not depend on InstallLocation to be filled out #255
Comments
In many cases when reaching out, you do not want to try to get the full path to a command that is available based on PATH variables, so don't attmept to get the full path.
InstallLocation is not always filled out in the registry because it is not required, so only check the value if it is not empty.
* stable: (GH-212) Do not strip switch char from uninstall args (maint) Use installshield installer when installshield (GH-255) Uninstaller should not depend on InstallLocation (GH-255) Add updateProcessPath to CommandExecutor (maint) formatting (GH-254) Ensure nupkg is removed on uninstall (doc) update help menus
Is this a fix for the issue discussed in this thread? I still can't get notepad++ to uninstall with autouninstaller enabled before installation. This is with Chocolatey 0.9.9.8. |
@masaeedu I think we should followup with a new issue. It should work if you have enabled autouninstaller before uninstallation. The caveat is that if you had NPP already installed and then used choco to reinstall it, it may not have caught a registry snapshot. |
@ferventcoder "The caveat is that if you had NPP already installed and then used choco to reinstall it, it may not have caught a registry snapshot." I believe this is what happened to me as I am currently dealing with the same issue. What does one do in this case? |
uninstall and reinstall. also autouninstaller should be on when you install |
@aronovgj thanks- let me try that. |
Auto uninstaller doesn't need to be on when you install. It will always capture the snapshot during the install no matter what. It just may not have anything to capture if there is no change to the registry. |
i was so sure... |
My experience is that it doesn't capture the registry snapshot. Is there any Github issue opened to address this? |
@i-give-up So you don't have NPP already installed and it is installing and doesn't capture a snapshot? And you are on on the latest version of chocolatey (0.9.9.11 as of this question)? |
No ticket yet filed for that. |
@ferventcoder I'm using choco 0.9.9.11. Testing the steps below with packages
Both gave me the message
Perhaps I should restart before installing with |
Step 1 is the issue, the snapshot can only detect registry changes. It may You'd need to uninstall manually before the choco install and maybe a You can always see the snapshots in On Wednesday, October 14, 2015, i-give-up [email protected] wrote:
Rob http://devlicio.us/blogs/rob_reynolds |
Yeah, sorry if I wasn't being clear before. What I meant to ask was that: seeing that the Auto Uninstaller doesn't work if you install a package via choco over an existing manual installation, is there any plan to make Auto Uninstaller work in such cases? |
Yes, but it's based on package opt-in that tells the install where the key is. This also has the nice side effect of not running the installer if it is already installed. |
The autoUninstaller looks for the existence of the registry key and the install path. However InstallPath could be empty as it is not required to be filled out. Only check InstallPath if it has a value.
The text was updated successfully, but these errors were encountered: