Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some packages use non-API variables like $installArguments #207

Closed
ferventcoder opened this issue Mar 26, 2015 · 8 comments
Closed

Some packages use non-API variables like $installArguments #207

ferventcoder opened this issue Mar 26, 2015 · 8 comments
Assignees
@ferventcoder
Labels
5 - Released FeatureParity Improvement Priority_HIGH
Milestone
0.9.9.3

Comments

@ferventcoder
Copy link
Member

Packages that incorrectly use variables that were never part of the api.

I won't call this a bug because it is most definitely a bug in the packages, not in Choco
@ferventcoder
Copy link
Member Author

This could sort of be related to #150

@ferventcoder ferventcoder added this to the 0.9.9.3 milestone Mar 26, 2015
@ferventcoder ferventcoder self-assigned this Mar 26, 2015
@ferventcoder ferventcoder changed the title Some packages use non-API variables like installarguments Some packages use non-API variables like $installArguments Mar 26, 2015
@ferventcoder
Copy link
Member Author

Like firefox being one of the big ones

@gep13
Copy link
Member

gep13 commented Mar 26, 2015

@ferventcoder which variables in particular are being used which shouldn't be?

@ferventcoder
Copy link
Member Author

$installArguments is passed to choco - but it is not given to the packages. However there was/is an environment variable we are passing, the broken packages are not using the environment variable, just the variable from choco

@BradKnowles
Copy link

I sent the Firefox maintainers a fix (basic null check set to empty string). It worked in my testing. May not be the long term fix, but can get the Firefox package back up and running in the meantime.

Here's the gist with log and fix info.

@gep13
Copy link
Member

gep13 commented Mar 27, 2015

@ferventcoder right, that is what I thought you were referring to, just wanted to make sure that we are on the same page.

ferventcoder added a commit that referenced this issue Mar 27, 2015
@ferventcoder
(GH-207) Some pkgs incorrectly use arguments
abe92f3 
* Set $installArguments to the environment variable
* Set $forcex86 to the environment variable
* Set $packageParameters to the environment variable
* Set $overrideArgs to the environment variable
@ferventcoder
Copy link
Member Author

I think I have this fixed.

@ferventcoder
Copy link
Member Author

Yes, this is fixed. Going to start getting the documentation together to ship a new version today.

ferventcoder added a commit that referenced this issue Mar 29, 2015
@ferventcoder
(GH-207) Set up variables for powershell scripts
aa89825 
Prior to calling the script, we need to set up variables so they are
available. To do that we redirect the call to a known powershell
script that will call the install/uninstall script. In this known
script we set up all of the variables appropriately so they are already
set when we call the actual script from the known script.
ferventcoder added a commit to ferventcoder/choco that referenced this issue Mar 29, 2015
@ferventcoder
Merge branch 'stable'
ce90c21 
* stable:
  (version) 0.9.9.3
  (doc) update nuspec / changelog for release
  (chocolateyGH-211) Use full path to msiexec
  (chocolateyGH-197) Uninstaller check for registry existence
  (chocolateyGH-167) Get-ChocolateyWebFile create directory
  (chocolateyGH-207) Set up variables for powershell scripts
  (chocolateyGH-202)(log) Enhance formatting escaping
  (chocolateyGH-202) Fix formatting on Noop logging
  (chocolateyGH-208) Do not escape curly braces in scripts
  (chocolateyGH-168) Retry .NET Fx if first install fails
  (chocolateyGH-168) .NET Framework 4.0 install egg/chicken
  (chocolateyGH-207) Some pkgs incorrectly use arguments
ferventcoder added a commit that referenced this issue Mar 30, 2015
@ferventcoder
(GH-207) pass switches correctly
d6c5e05 
Only pass a switch if it is specified
ferventcoder added a commit that referenced this issue Mar 30, 2015
@ferventcoder
Merge branch 'stable'
1d6c362 
* stable:
  (version) 0.9.9.4
  (doc) update changelog / nuspec
  (GH-207) pass switches correctly
  (GH-215) The term 'false' is not recognized
@ferventcoder ferventcoder mentioned this issue Apr 1, 2015
Closed
@ferventcoder ferventcoder mentioned this issue Apr 9, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released FeatureParity Improvement Priority_HIGH
Projects
None yet
Milestone
0.9.9.3
Development

No branches or pull requests
3 participants
@ferventcoder @gep13 @BradKnowles