Building non-release version of choco includes logs/config folders #2055
Assignees
Labels
5 - Released
Bug
NO RELEASE NOTES
Should not be included in the release notes - not enhancing or fixing end product.
Milestone
Comments
ferventcoder
added
Bug
4 - Done
NO RELEASE NOTES
ferventcoder
added a commit
that referenced
this issue
May 24, 2020
When building choco for official release, Chocolatey uses the machine installation location for writing out logs and checking for the existence of a config file. When in a non-official release, it uses the output folder, which means it will be packaged up inside the package. This is bad because it later overwrites the existing log files, and it overwrites the config, resetting/removing any settings one may be depending on. This only affects a non-official release, or releases that are used for testing. Ensure the logs/config folders are removed and not packaged into the nuget packaging.
ferventcoder
added a commit
that referenced
this issue
May 24, 2020
* stable: (GH-2055) remove logs/config folder in nupkg (version) 0.10.16-beta
johnstevenson
added a commit
to johnstevenson/choco
that referenced
this issue
Jun 20, 2020
* upstream/master: (21 commits) (doc) Changed cla links from clahub to cla-assistant (chocolateyGH-2055) remove logs/config folder in nupkg (version) 0.10.16-beta (chocolateyGH-2023) Install git in the docker container (chocolateyGH-1859) Fix error message for missing 32-bit URL (chocolateyGH-1859) Fix error message for missing 32-bit URL (chocolateyGH-2051) Fix: workingDirectory always replaced w/cacheLocation (chocolateyGH-1983) exit-on-reboot-detected environment variable (maint) update resharper settings (maint) formatting (chocolateyGH-1843) Fix: search exact all versions returns 1 (chocolateyGH-1020) fix build (chocolateyGH-1020) Direct platform only for windows tests (chocolateyGH-1020) WindowsOnly tests by platform, not ignore (chocolateyGH-1020) Docker add ChocolateyInstall Env Var (chocolateyGH-1020) Docker use code_drop instead of build_output (doc) Update mono installation instructions in README (chocolateyGH-1020) Dockerfile and Travis to Mono 5.20.1 (chocolateyGH-1020) Add mono-4.5 configuration Add missing start of comment block ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If you are building a test version of Chocolatey, the logs and config folders get written to the nupkg, which then overwrite configs and logs of the installed version when you upgrade. This is due to the build for the release version is using where Chocolatey is installed on the machine to write output and check for the existence of a config file. However a build that is not official won't be doing that as of #1949.
The text was updated successfully, but these errors were encountered: