Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] ability to get consistent hash of ConfigFileSettings class #1612

Closed
gep13 opened this issue Jul 13, 2018 · 3 comments
Closed

[API] ability to get consistent hash of ConfigFileSettings class #1612

gep13 opened this issue Jul 13, 2018 · 3 comments
Assignees
@gep13
Labels
5 - Released API Improvement
Milestone
0.10.12

Comments

@gep13
Copy link
Member

gep13 commented Jul 13, 2018

We need the ability to be able to quickly determine whether something has changed with the chocolatey.config file. This would allow us to make informed decisions about whether something has changed in the configuration since the last time it was inspected. This is typically done through the GetHashCode code of an object, however, in order for this to be reliable, some modifications are required to ensure that the results are consistent.
@gep13 gep13 added this to the 0.10.12 milestone Jul 13, 2018
@gep13 gep13 self-assigned this Jul 13, 2018
gep13 added a commit to gep13/choco that referenced this issue Jul 14, 2018
@gep13
(chocolateyGH-1612) Added extension method and struct
fba9079 
- To allow for correctly generating hash code of objects
gep13 added a commit to gep13/choco that referenced this issue Jul 14, 2018
@gep13
(chocolateyGH-1612) Updated classes to override methods
7f060ea 
- To allow for correct generation of hash codes
- This will be used to validate changes to chocolatey.config file
@gep13 gep13 mentioned this issue Sep 27, 2018
Merged
@ferventcoder
Copy link
Member

I want to say this fixes a bug as well?

@ferventcoder
Copy link
Member

With grabbing the config file and thinking there may be some changes?

@gep13
Copy link
Member Author

gep13 commented Sep 27, 2018

@ferventcoder possibly. A comparison of the hash would still need to be done in order to see if a change had occurred.

gep13 added a commit to gep13/choco that referenced this issue Oct 9, 2018
@gep13
(chocolateyGH-1612) Added extension method and struct
1dd642c 
- To allow for correctly generating hash code of objects
gep13 added a commit to gep13/choco that referenced this issue Oct 9, 2018
@gep13
(chocolateyGH-1612) Updated classes to override methods
db55e2f 
- To allow for correct generation of hash codes
- This will be used to validate changes to chocolatey.config file
gep13 added a commit to gep13/choco that referenced this issue Oct 9, 2018
@gep13
(chocolateyGH-1612) Added extension method and struct
134596e 
- To allow for correctly generating hash code of objects
gep13 added a commit to gep13/choco that referenced this issue Oct 9, 2018
@gep13
(chocolateyGH-1612) Updated classes to override methods
4c85719 
- To allow for correct generation of hash codes
- This will be used to validate changes to chocolatey.config file
gep13 added a commit that referenced this issue Oct 9, 2018
@gep13
Merge pull request #1613 from gep13/feature/GH-1612
a37769c 
(GH-1612) Added consistent generation of hash code
@gep13 gep13 closed this as completed Oct 9, 2018
@gep13 gep13 added the 4 - Done label Oct 9, 2018
gep13 added a commit that referenced this issue Oct 10, 2018
@gep13
Merge branch 'stable'
8052beb 
* stable:
  (version) 0.10.12-beta
  (doc) Updated release notes
  (GH-1612) Updated classes to override methods
  (GH-1612) Added extension method and struct
  (maint) Corrected whitespace
@ferventcoder ferventcoder changed the title Add ability to get consistent hash of ConfigFileSettings class [API] ability to get consistent hash of ConfigFileSettings class Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
5 - Released API Improvement
Projects
None yet
Milestone
0.10.12
Development

No branches or pull requests
2 participants
@ferventcoder @gep13