-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxy bypass list with "*" will return regex quantifier parsing errors #1532
Comments
If someone adds a value with a wild card ("*") to the proxy bypass list, instead of configuring it properly, it will return an error instead: "parsing "*.localhost.com" - Quantifier {x,y} following nothing." When the wildcard is found, it needs to be converted to a proper regext.
* stable: (doc) update release notes (GH-1529) Fix: install of choco exit code 1 (GH-1532) Fix: proxy bypass with "*" causes regex error (GH-1531) Hold exclusive locks on non-essential logs (maint) formatting (maint) update copyright for assemblies (GH-1527) Fix: NuGet cache removal fixes (GH-1527) Use machine temp with systemprofile
I still get this error with 0.10.11. Wasn't the fix published with 0.10.10? The merge failed due to test coverage if Im not mistaken. @ferventcoder What is the status on this? |
I also still get this error and this causes me a lot of problems. |
@johlandabee interesting - I'll follow up on the issue you created as a followup. This was definitely fixed and verified for 0.10.10 - no merge failed here. |
I have the same error with Chocolatey v0.10.11 on Windows 10.
Workaround : remove NO_PROXY env var before choco execution |
The documentation is very clear on this:
So, in my opinion, this should not be fixed. |
@t0r0X Actually, most implementations do use globbing and not regex to match no_proxy entries. Infact, your example does not work for such, as it will match |
@johlandabee please open a new issue related to this. Can I ask that if you set the proxy bypass list INSIDE of chocolatey configuration whether it works with the regex described? And yes, |
@ferventcoder That works. Thanks. Seems like the choco config weights more than the environment variable after all. I've set the following:
|
It's a bit of pain that chocolatey doesn't properly use no_proxy environment variable and that we need a custom "no_proxy" setting for chocolatey... |
|
thxs, it solved my problem |
Say you add "*.localhost.com" to the proxy bypass list. Instead of configuring it properly, it will return an error with "parsing "*.localhost.com" - Quantifier {x,y} following nothing."
The text was updated successfully, but these errors were encountered: