-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escape package registry information to reduce unreadable files #1505
Comments
gep13
added a commit
to gep13/choco
that referenced
this issue
Feb 22, 2018
- Also, when de-serializing, if a .backup file exists, remove original - Warn user that .backup file exists and needs to be corrected
gep13
added a commit
to gep13/choco
that referenced
this issue
Feb 22, 2018
- Also, when de-serializing, if a .backup file exists, remove original - Warn user that .backup file exists and needs to be corrected
gep13
added a commit
to gep13/choco
that referenced
this issue
Feb 22, 2018
- Also, when de-serializing, if a .backup file exists, remove original - Warn user that .backup file exists and needs to be corrected
gep13
added a commit
to gep13/choco
that referenced
this issue
Feb 23, 2018
- Also, when de-serializing, if a .backup file exists, remove original - Warn user that .backup file exists and needs to be corrected
gep13
added a commit
to gep13/choco
that referenced
this issue
Feb 23, 2018
- Also, when de-serializing, if a .backup file exists, remove original - Warn user that .backup file exists and needs to be corrected
ferventcoder
added a commit
that referenced
this issue
Feb 26, 2018
(GH-1505) Ensure package information from registry is escaped
ferventcoder
added a commit
that referenced
this issue
Feb 26, 2018
Keeping in mind this is an XML document and it does have Cdata elements, give the user an area of concentration.
ferventcoder
changed the title
Package Registry Information may need to be escaped
Escape package registry information to reduce unreadable files
Mar 4, 2018
This was referenced Apr 24, 2018
ferventcoder
added a commit
that referenced
this issue
May 4, 2018
The change made for GH-1505 caused the registry information to escape a little too well, so some of the quotes and apostrophes were being saved as `'` and `"`. When it came time for automatic uninstaller to remove the software that was found in the snapshot, it didn't know how to work with those escaped double quotes and gave up very quickly. To fix this, don't escape those two items, but handle any that may have already had this adjustment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When creating a registry backup, it is possible that Chocolatey creates a file that looks like this:
The additional characters in the Display Name are causing problems when trying to load the registry snapshot again
The text was updated successfully, but these errors were encountered: