Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging: PowerShell script contents logging should not error if they have contents mistaken for log formatting #1489

Closed
ferventcoder opened this issue Feb 12, 2018 · 0 comments
Closed

logging: PowerShell script contents logging should not error if they have contents mistaken for log formatting #1489

ferventcoder opened this issue Feb 12, 2018 · 0 comments
Assignees
@ferventcoder
Labels
5 - Released Bug Priority_LOW
Milestone
0.10.9

Comments

@ferventcoder
Copy link
Member

If logging the contents of the PowerShell script go through formatting, there is a good chance that the formatter will mess it up somewhere. This is due to the use of { and } in PowerShell. So don't send it through formatting.
@ferventcoder ferventcoder added this to the 0.10.9 milestone Feb 12, 2018
@ferventcoder ferventcoder self-assigned this Feb 12, 2018
ferventcoder added a commit to ferventcoder/choco that referenced this issue Feb 20, 2018
@ferventcoder
(chocolatey#1489) Log PowerShell contents w/out formatting
dbc0a3b 
If logging the contents of the PowerShell script go through formatting,
there is a good chance that the formatter will mess it up somewhere.
This is due to the use of `{` and `}` in PowerShell. Ensure it is not
sent through formatting.
ferventcoder added a commit that referenced this issue Feb 20, 2018
@ferventcoder
(#1489) Log PowerShell contents w/out formatting
48a18b0 
If logging the contents of the PowerShell script go through formatting,
there is a good chance that the formatter will mess it up somewhere.
This is due to the use of `{` and `}` in PowerShell. Ensure it is not
sent through formatting.
ferventcoder added a commit that referenced this issue Feb 20, 2018
@ferventcoder
Merge branch 'stable'
cdf0938 
* stable: (35 commits)
  (GH-1478) Upgrade 7z to 18.1
  (GH-1490) Remove quotes/apostrophes surrounding parameter
  (maint) virtualize get_package_information
  (maint) virtualize all calls in NuGetService
  (GH-100) Log without colorization
  (GH-100) add no color feature/option
  (GH-100) add no color log4net config files
  (maint) formatting
  (#1489) Log PowerShell contents w/out formatting
  (maint) Some options could be achieved w/FOSS
  (maint) Add instructions for strong naming NuGet
  (maint) update licensing code
  (GH-1488) License validation logging
  (specs) add pack scenario nuspec
  (maint) Whitespace changes
  (GH-1500) Disable re-validation of Chocolatey License File
  (doc) update etiquette statement
  (build) allow builds with any .NET 4.x
  (doc) update licensed changelog
  (maint) update licensing
  ...

# Conflicts:
#	README.md
@ferventcoder ferventcoder changed the title PowerShell script contents should not log through formatting PowerShell script contents logging should not error if they have contents mistaken for log formatting Mar 4, 2018
@ferventcoder ferventcoder changed the title PowerShell script contents logging should not error if they have contents mistaken for log formatting logging: PowerShell script contents logging should not error if they have contents mistaken for log formatting Mar 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Bug Priority_LOW
Projects
None yet
Milestone
0.10.9
Development

No branches or pull requests
2 participants
@ferventcoder @gep13