Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new - Package Templates - Do not treat binaries in template as text files #1385

Closed
ferventcoder opened this issue Aug 20, 2017 · 0 comments
Closed

new - Package Templates - Do not treat binaries in template as text files #1385

ferventcoder opened this issue Aug 20, 2017 · 0 comments
Assignees
@ferventcoder
Labels
5 - Released Customer Improvement
Milestone
0.10.8

Comments

@ferventcoder
Copy link
Member

ferventcoder commented Aug 20, 2017 •
edited
Loading

If any of the following are found in a template, they should just be copied over directly to the package:

  • executables: .exe, .msi , .msu, .msp, .mst
  • archives: .7z, .zip, .rar, .gz,.tar, .sfx, .iso
  • certificates: .cer, .crt, .der, .p7b, .pfx, .p12, .pem
@ferventcoder ferventcoder added this to the 0.10.8 milestone Aug 20, 2017
@ferventcoder ferventcoder self-assigned this Aug 20, 2017
ferventcoder added a commit that referenced this issue Aug 21, 2017
@ferventcoder
(GH-1385) Template - do not treat binary as text file
9d45404 
When a binary, such as an executable, zip, or cert is found in a
template, copy that file directly across without attempting to read the
file and replace template tokens.
ferventcoder added a commit to ferventcoder/choco that referenced this issue Aug 21, 2017
@ferventcoder
Merge branch 'stable'
1c5e62b 
* stable:
  (chocolateyGH-1386) Default Template - Overall help and todo
  (chocolateyGH-1257) AutoUninstaller: package opt-out
  (maint) tab - add pro list options
  (chocolateyGH-1383) Fix - no pkg args cause "value cannot be null"
  (chocolateyGH-1385) Template - do not treat binary as text file
  (maint) typo
  (maint) Do not package pdb w/exe
  (doc) update generated docs
@ferventcoder ferventcoder changed the title Package Templates - Do Not Treat Binaries in Template as Text Files new - Package Templates - Do Not Treat Binaries in Template as Text Files Aug 29, 2017
@ferventcoder ferventcoder changed the title new - Package Templates - Do Not Treat Binaries in Template as Text Files new - Package Templates - Do not treat binaries in template as text files Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Customer Improvement
Projects
None yet
Milestone
0.10.8
Development

No branches or pull requests
2 participants
@ferventcoder @gep13