Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

list - Sub-command should not require admin access (and not prompt) #1353

Closed
Skons opened this issue Jul 5, 2017 · 4 comments
Closed

list - Sub-command should not require admin access (and not prompt) #1353

Skons opened this issue Jul 5, 2017 · 4 comments
Assignees
@ferventcoder
Labels
5 - Released Improvement
Milestone
0.10.8

Comments

@Skons
Copy link

Skons commented Jul 5, 2017

When not providing -y the command does not continue but waits for input. When i provide -y i get a 20 second warning. When confirming with -y on the cli, i already confirmed the fact that i do not run an elevated prompt, and thus i should not get a 20 seconds timeout.

Also, it is not a function that really would require elevation.

image
@ferventcoder
Copy link
Member

@Skons I see what you mean - it could require elevation, if you are running anything but list. We should be able to handle this though.

@ferventcoder ferventcoder self-assigned this Jul 5, 2017
@ferventcoder ferventcoder added this to the 0.10.8 milestone Jul 5, 2017
@ferventcoder
Copy link
Member

I was thinking there was a similar request for this enhancement (making listing not require admin)

@ferventcoder ferventcoder changed the title Choco list sources should not warn about elevated prompt List sub-command should not require admin access (and not prompt) Jul 5, 2017
@ferventcoder
Copy link
Member

This will be in 0.10.8

@Skons
Copy link
Author

Skons commented Jul 6, 2017

When researching this problem I came across issue #893

ferventcoder added a commit that referenced this issue Jul 9, 2017
@ferventcoder
(GH-1353) List subcommand does not need admin
30407e5 
When running the list subcommand, such as `choco source list`, it
doesn't need admin privileges to provide read only information, so the
check against whether a command may require admin privileges should be
a bit smarter to see what sub-command it is about to run.
ferventcoder added a commit that referenced this issue Jul 9, 2017
@ferventcoder
Merge branch 'stable'
64469a6 
* stable:
  (doc) update CONTRIBUTING
  (doc) update licensed changelog
  (GH-1335) Read-Host -AsSecureString
  (maint) formatting
  (GH-1353) List subcommand does not need admin
  (doc) update generated docs
@ferventcoder ferventcoder changed the title List sub-command should not require admin access (and not prompt) list - sub-command should not require admin access (and not prompt) Aug 29, 2017
@ferventcoder ferventcoder changed the title list - sub-command should not require admin access (and not prompt) list - Sub-command should not require admin access (and not prompt) Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Improvement
Projects
None yet
Milestone
0.10.8
Development

No branches or pull requests
3 participants
@ferventcoder @gep13 @Skons