Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trace logging should only occur on when trace is enabled #1309

Closed
ferventcoder opened this issue May 23, 2017 · 0 comments
Closed

Trace logging should only occur on when trace is enabled #1309

ferventcoder opened this issue May 23, 2017 · 0 comments
Assignees
@ferventcoder
Labels
5 - Released Bug
Milestone
0.10.6

Comments

@ferventcoder
Copy link
Member

Restrict tracing output to when trace is enabled.
@ferventcoder ferventcoder added this to the 0.10.6 milestone May 23, 2017
@ferventcoder ferventcoder self-assigned this May 23, 2017
ferventcoder added a commit that referenced this issue May 29, 2017
@ferventcoder
(GH-1309) Restrict trace output
58cd651 
Trace logging should only occur when tracing is enabled. It can provide
a pretty significant amount of logging, so ensure it only happens if
someone has enabled `--trace`.
ferventcoder added a commit that referenced this issue May 29, 2017
@ferventcoder
Merge branch 'pr1264' into stable
5469ccd 
* pr1264: (26 commits)
  (maint) COMMITTERS - EOL change to CRLF
  (doc) update CONTRIBUTING/COMMITTERS
  (GH-1241) XmlService - trace logging information
  (maint) formatting
  (GH-1241) FileSystem - move file creates directory
  (GH-1241) Explicitly handle closing
  (maint) formatting
  (GH-1292) Ensure manifest extracted on unpackself
  (log) replace_file use new lines for log
  (maint) update CHANGELOG / nuspec
  (maint) nuspec - add info links to description
  (maint) clean up lib nuspec
  (GH-1311) Install-ChocolateyPowershellCommand File/FileFullPath aliases
  (GH-1284) ensure file/filefullpath on functions
  (maint) ReadMe updates
  (GH-1241) Use process id with update file
  (maint) restrict list start/end messages to log file
  (GH-1309) Restrict trace output
  (GH-1241) More Robust File.Replace
  (GH-1241) Use write_file for stream writing
  ...
ferventcoder added a commit that referenced this issue May 29, 2017
@ferventcoder
Merge branch 'stable'
f153f21 
* stable: (26 commits)
  (maint) COMMITTERS - EOL change to CRLF
  (doc) update CONTRIBUTING/COMMITTERS
  (GH-1241) XmlService - trace logging information
  (maint) formatting
  (GH-1241) FileSystem - move file creates directory
  (GH-1241) Explicitly handle closing
  (maint) formatting
  (GH-1292) Ensure manifest extracted on unpackself
  (log) replace_file use new lines for log
  (maint) update CHANGELOG / nuspec
  (maint) nuspec - add info links to description
  (maint) clean up lib nuspec
  (GH-1311) Install-ChocolateyPowershellCommand File/FileFullPath
aliases
  (GH-1284) ensure file/filefullpath on functions
  (maint) ReadMe updates
  (GH-1241) Use process id with update file
  (maint) restrict list start/end messages to log file
  (GH-1309) Restrict trace output
  (GH-1241) More Robust File.Replace
  (GH-1241) Use write_file for stream writing
  ...

# Conflicts:
#	CONTRIBUTING.md
#	README.md
ferventcoder added a commit that referenced this issue May 29, 2017
@ferventcoder
(GH-1309) Support this.Log.Trace()
95f2d0e 
Allow calling trace directly and have it do the appropriate thing. If
trace is called through a logger, redirect to the trace method.
ferventcoder added a commit that referenced this issue May 29, 2017
@ferventcoder
(GH-1309) convert trace calls to this.Log.Trace()
f7f306a 
All current calls to tracing should be simplified so the calls are
easier to see.
ferventcoder added a commit that referenced this issue May 29, 2017
@ferventcoder
Merge branch 'stable'
2b17f58 
* stable:
  (doc) update c# design section
  (spec)(doc) MockLogger.LogMessagesToConsole usage
  (spec) ensure Trace messages are not logged
  (maint) note about resetting loggers
  (GH-1309) convert trace calls to this.Log.Trace()
  (GH-1309) Support this.Log.Trace()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Bug
Projects
None yet
Milestone
0.10.6
Development

No branches or pull requests
2 participants
@ferventcoder @gep13