Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source/list - Support for Admin Only Sources - Limit non-admin list to self service only #1265

Closed
lukegriffith opened this issue Apr 26, 2017 · 4 comments
Closed

source/list - Support for Admin Only Sources - Limit non-admin list to self service only #1265

lukegriffith opened this issue Apr 26, 2017 · 4 comments
Assignees
@ferventcoder
Labels
5 - Released Customer Improvement Pro/Business
Milestone
0.10.8

Comments

@lukegriffith
Copy link

Currently with feature useBackgroundServiceWithSelfServiceSourcesOnly enabled, a user without admin permissions can do choco list and return items from all configured sources by default, including packages from sources that are not configured for self service.

Would it be possible for non elevated users to only have self service packages returned, as its the only items they can actually install.
@ferventcoder
Copy link
Member

ferventcoder commented Apr 26, 2017 •
edited
Loading

This is interesting. I like it. By the way, I set this up - https://github.com/chocolatey/chocolatey-licensed-issues

chocolatey/chocolatey-licensed-issues#6

@ferventcoder ferventcoder self-assigned this Apr 26, 2017
@ferventcoder ferventcoder added this to the 0.10.7 milestone Apr 26, 2017
@ferventcoder
Copy link
Member

This would probably need to be logged over with ChocolateyGUI as well.

@lukegriffith
Copy link
Author

Awesome, I'll take a look. I'll also get it logged there now, I know from previous spelunking I've seen .IsElevated() so i imagine it should be possible :P

@ferventcoder
Copy link
Member

I'd agree.

@ferventcoder ferventcoder modified the milestones: 0.10.7, 0.10.8 Jun 6, 2017
@ferventcoder ferventcoder added this to the 0.10.8 milestone Aug 27, 2017
@ferventcoder ferventcoder changed the title Limit non-admin list to self service only. Admin Only Sources - Limit non-admin list to self service only Aug 27, 2017
@ferventcoder ferventcoder changed the title Admin Only Sources - Limit non-admin list to self service only Support for Admin Only Sources - Limit non-admin list to self service only Aug 27, 2017
@ferventcoder ferventcoder mentioned this issue Aug 27, 2017
Closed
ferventcoder added a commit that referenced this issue Aug 29, 2017
@ferventcoder
(GH-1265) Support for Admin only sources
896f22d 
Support adding admin only sources, sources that only admins would be
able to see. For open source, this addition will be a noop as it won't
make a difference (similar to self-service sources).
ferventcoder added a commit that referenced this issue Aug 29, 2017
@ferventcoder
Merge branch 'stable'
0906be8 
* stable:
  (maint) fully qualify regex in scripts
  (GH-1133) Autouninstaller - Use Uninstall Args / Override
  (GH-1133) autouninstaller - skip if package is missing
  (GH-1133) Package dependency check globally available
  (maint) make classes public
  (GH-1155) More comprehensive warn on nupkg/nuspec use
  (GH-1155) Fix: params are unused w/nupkg
  (GH-1394) Fix: API - return self-service setting for sources
  (GH-1265) Support for Admin only sources
  (GH-1393) Get-PackageParameters function
  (GH-1386) remove default admin tag
  (doc) fix grammar
  (maint) remove choco.pdb if found on upgrade
@ferventcoder ferventcoder changed the title Support for Admin Only Sources - Limit non-admin list to self service only source/list - Support for Admin Only Sources - Limit non-admin list to self service only Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Customer Improvement Pro/Business
Projects
None yet
Milestone
0.10.8
Development

No branches or pull requests
3 participants
@ferventcoder @gep13 @lukegriffith