Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally overwrite the app manifest on upgrades of Chocolatey #1206

Open
ferventcoder opened this issue Mar 22, 2017 · 3 comments
Open

Conditionally overwrite the app manifest on upgrades of Chocolatey #1206

ferventcoder opened this issue Mar 22, 2017 · 3 comments
Labels
0 - Backlog 0 - _Triaging Improvement Priority_LOW Up For Grabs
Milestone
1.x

Comments

@ferventcoder
Copy link
Member

Following up #1054, determine how not to overwrite the app manifest if a user has made changes to it.
ferventcoder added a commit that referenced this issue Mar 22, 2017
@ferventcoder
(GH-1054) Document requested execution levels
787b4b5 
Document requestedExecutionLevel and how each applies and changes the
behavior of Chocolatey. Note that folks will need to do this every time
they upgrade until GH-1206 is implemented.
@ferventcoder ferventcoder mentioned this issue Mar 22, 2017
Closed
@ferventcoder ferventcoder added this to the 1.x milestone Mar 22, 2017
@ferventcoder
Copy link
Member Author

This is open for discussion.

@AdmiringWorm
Copy link
Member

storing a small text file with the hash of the manifest file when installed?
If it have changed, don't overwrite it?
Just thinking out loud.

@ferventcoder ferventcoder modified the milestones: 1.x, 0.10.4 Mar 23, 2017
@ferventcoder
Copy link
Member Author

storing a small text file with the hash of the manifest file when installed?
If it have changed, don't overwrite it?

If we've changed it for the next release, how do we know if we are looking at the old version or someone's local changes?

What happens if we make necessary changes to the file and the user has also made changes in the same spot?

There are just two questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - Backlog 0 - _Triaging Improvement Priority_LOW Up For Grabs
Projects
None yet
Milestone
1.x
Development

No branches or pull requests
2 participants
@ferventcoder @AdmiringWorm