chocolateyBeforeModify.ps1 does not get called for dependent packages #1092

6opuc · 2016-12-16T13:01:05Z

I have two packages A and B.
Package B is a dependency of package A.
Currently both packages are installed with version 1.0
Both packages are at version 1.1 in package repository(both packages are newer than installed ones)
After calling "choco upgrade A" both packages gets updated to version 1.1(which is good)
But chocolateyBeforeModify.ps1 gets called only for package A(I expected that chocolateyBeforeModify.ps1 should be called for package B also)

ferventcoder · 2016-12-16T16:13:04Z

That's interesting and definitely not desired. I find it odd that it doesn't handle that situation accurately.

ferventcoder · 2016-12-16T16:14:37Z

As the issue template requested, can you provide a gist of the debug / verbose output? You should have this from what you ran already. It will be in C:\ProgramData\chocolatey\logs\chocolatey.log.

Once we have that, it will provide some better terms for evaluation.

6opuc · 2016-12-16T16:23:51Z

Ok, i'll post it on monday.
Thanks for Your efforts!

ferventcoder · 2016-12-16T16:26:57Z

Thank you. 👍

6opuc · 2016-12-19T04:30:13Z

I've attached chocolatey.log file: https://github.com/chocolatey/choco/files/660065/chocolatey.log.txt

Command issued in console was: choco upgrade itsk.af.local -y

Package dependency tree looks like this:
itsk.af.local
-> itsk.af.db.local
-> itsk.af.dispatcher.local
-> itsk.af.integration.local
-> itsk.af.scheduler.local
-> itsk.af.api.local
-> itsk.af.client.local
-> itsk.af.frontend.local

Each package has tools\chocolateyBeforeModify.ps1 with the same content:
Write-Host $MyInvocation.MyCommand.Definition

But tools\chocolateyBeforeModify.ps1 gets called only for itsk.af.local

billw2012 · 2018-04-12T15:44:21Z

This still appears to be a broken, please fix.

ferventcoder · 2018-04-12T17:12:20Z

I think we know why this is occurring - we'll prolly need to do some additional checks closer to when those dependent packages are discovered for upgrade.

tpidor · 2018-12-11T05:06:01Z

We have the same problem as well. We're using a meta-package which depends on multiple packages.
Dependencies for example:
meta-package
-> install-pkg-a
-> install-pkg-b
However, one of the parent packages install-pkg-a needs to uninstall the installed msi first before re-installing. We use the chocolateyBeforeModify.ps1 to uninstall the previous version before upgrading. This is working well when doing choco upgrade install-pkg-a, it managed to uninstall the previous version. But when doing choco upgrade meta-package, the new version of install-pkg-a does not run chocolateyBeforeModify.ps1. My next attempt on this issue is to put uninstall steps from chocolateyBeforeModify.ps1 into chocolateyinstall.ps1.

oldium · 2020-05-08T19:26:28Z

Users of keepass package (including me) are repeatedly facing this issue (just see the comments). Would it be possible to fix this, please?

…and Install scripts, as workaround for chocolatey/choco#1092

This addition is necessary, as many occasions may arise where installing one package involves updating an already-installed dependency. In these cases we should still be running a beforeModify script if it's present, and this facilitates that.

This test added ensures that when we are upgrading a package, both its own and any dependencies' beforeModify are run so that we can properly update dependencies which might need to shut down a long-running service before being upgraded.

(#1092) Ensure chocolateyBeforeModify.ps1 is run for dependencies

choco-bot · 2023-03-14T19:45:34Z

🎉 This issue has been resolved in version 1.3.1 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

This addition is necessary, as many occasions may arise where installing one package involves updating an already-installed dependency. In these cases we should still be running a beforeModify script if it's present, and this facilitates that. (cherry picked from commit 3a30cbc) # Conflicts: # src/chocolatey.tests/infrastructure.app/services/ChocolateyPackageServiceSpecs.cs

This test added ensures that when we are upgrading a package, both its own and any dependencies' beforeModify are run so that we can properly update dependencies which might need to shut down a long-running service before being upgraded. (cherry picked from commit 49cc8d7) # Conflicts: # src/chocolatey.tests.integration/chocolatey.tests.integration.csproj # src/chocolatey.tests.integration/scenarios/InstallScenarios.cs # src/chocolatey.tests.integration/scenarios/UninstallScenarios.cs # src/chocolatey.tests.integration/scenarios/UpgradeScenarios.cs

Changes originally in 9f5d9cc, adapted for the current develop branch and the changes therein.

Changes originally in 9f5d9cc, adapted for the current develop branch and the changes therein. Additionally, replaced and obsoleted some overloads of public (why?) methods that have unused method arguments and made them protected.

This addition is necessary, as many occasions may arise where installing one package involves updating an already-installed dependency. In these cases we should still be running a beforeModify script if it's present, and this facilitates that. (cherry picked from commit 3a30cbc) # Conflicts: # src/chocolatey.tests/infrastructure.app/services/ChocolateyPackageServiceSpecs.cs

This test added ensures that when we are upgrading a package, both its own and any dependencies' beforeModify are run so that we can properly update dependencies which might need to shut down a long-running service before being upgraded. (cherry picked from commit 49cc8d7) # Conflicts: # src/chocolatey.tests.integration/chocolatey.tests.integration.csproj # src/chocolatey.tests.integration/scenarios/InstallScenarios.cs # src/chocolatey.tests.integration/scenarios/UninstallScenarios.cs # src/chocolatey.tests.integration/scenarios/UpgradeScenarios.cs

Changes originally in 9f5d9cc, adapted for the current develop branch and the changes therein. Additionally, replaced and obsoleted some overloads of public (why?) methods that have unused method arguments and made them protected.

This addition is necessary, as many occasions may arise where installing one package involves updating an already-installed dependency. In these cases we should still be running a beforeModify script if it's present, and this facilitates that. (cherry picked from commit 3a30cbc)

This test added ensures that when we are upgrading a package, both its own and any dependencies' beforeModify are run so that we can properly update dependencies which might need to shut down a long-running service before being upgraded. (cherry picked from commit 49cc8d7) # Conflicts: # src/chocolatey.tests.integration/chocolatey.tests.integration.csproj # src/chocolatey.tests.integration/scenarios/InstallScenarios.cs # src/chocolatey.tests.integration/scenarios/UninstallScenarios.cs # src/chocolatey.tests.integration/scenarios/UpgradeScenarios.cs

Changes originally in 9f5d9cc, adapted for the current develop branch and the changes therein. Additionally, replaced and obsoleted some overloads of public (why?) methods that have unused method arguments and made them protected.

(#1092) Incorporate beforemodify changes into develop branch

ferventcoder added the 0 - _Triaging label Dec 16, 2016

ferventcoder added Bug Up For Grabs 0 - Backlog and removed 0 - _Triaging labels Apr 12, 2018

ferventcoder added this to the 0.10.12 milestone Apr 12, 2018

ferventcoder modified the milestones: 0.10.12, 0.10.13 May 3, 2018

ferventcoder modified the milestones: 0.10.13, 0.10.14 Mar 15, 2019

ferventcoder modified the milestones: 0.10.14, 0.10.15 Apr 1, 2019

gep13 modified the milestones: 0.10.15, 0.10.16 May 31, 2019

pauby modified the milestones: 0.10.16, 0.10.x May 11, 2021

TheCakeIsNaOH mentioned this issue Jun 20, 2022

(git.install) gpg-agent.exe not killed before git package upgrade chocolatey-community/chocolatey-packages#1451

Closed

AdmiringWorm mentioned this issue Jul 5, 2022

(git.install) Terminate gpg-agent as part of install? chocolatey-community/chocolatey-packages#1938

Closed

brogers5 added a commit to brogers5/chocolatey-packages-community that referenced this issue Jul 5, 2022

(git.install) Terminate gpg-agent instances within both BeforeModify …

97b5ec1

…and Install scripts, as workaround for chocolatey/choco#1092

brogers5 added a commit to brogers5/chocolatey-packages-community that referenced this issue Jul 5, 2022

(git.install) Terminate gpg-agent instances within both BeforeModify …

0feb48f

…and Install scripts, as workaround for chocolatey/choco#1092

brogers5 mentioned this issue Jul 6, 2022

(git.install) Terminate gpg-agent when indirectly upgrading chocolatey-community/chocolatey-packages#1945

Merged

11 tasks

vexx32 mentioned this issue Feb 28, 2023

(#1092) Ensure chocolateyBeforeModify.ps1 is run for dependencies #3051

Merged

10 tasks

vexx32 added 3 - Review and removed Up For Grabs 0 - Backlog labels Mar 14, 2023

vexx32 self-assigned this Mar 14, 2023

gep13 added a commit that referenced this issue Mar 14, 2023

Merge pull request #3051 from vexx32/1092-beforemodify

b1c877b

(#1092) Ensure chocolateyBeforeModify.ps1 is run for dependencies

vexx32 added 4 - Done and removed 3 - Review labels Mar 14, 2023

vexx32 closed this as completed Mar 14, 2023

vexx32 added 5 - Released and removed 4 - Done labels Mar 14, 2023

vexx32 added a commit to vexx32/choco that referenced this issue Mar 14, 2023

(chocolatey#1092) Pull beforeModify changes into develop

707ae3e

Changes originally in 9f5d9cc, adapted for the current develop branch and the changes therein.

vexx32 mentioned this issue Mar 14, 2023

(#1092) Incorporate beforemodify changes into develop branch #3065

Merged

10 tasks

gep13 added a commit that referenced this issue Mar 16, 2023

Merge pull request #3065 from vexx32/beforemodify-in-v2

8879f26

(#1092) Incorporate beforemodify changes into develop branch

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chocolateyBeforeModify.ps1 does not get called for dependent packages #1092

chocolateyBeforeModify.ps1 does not get called for dependent packages #1092

6opuc commented Dec 16, 2016 •

edited

Loading

ferventcoder commented Dec 16, 2016

ferventcoder commented Dec 16, 2016

6opuc commented Dec 16, 2016

ferventcoder commented Dec 16, 2016

6opuc commented Dec 19, 2016

billw2012 commented Apr 12, 2018 •

edited

Loading

ferventcoder commented Apr 12, 2018

tpidor commented Dec 11, 2018

oldium commented May 8, 2020

choco-bot commented Mar 14, 2023

chocolateyBeforeModify.ps1 does not get called for dependent packages #1092

chocolateyBeforeModify.ps1 does not get called for dependent packages #1092

Comments

6opuc commented Dec 16, 2016 • edited Loading

ferventcoder commented Dec 16, 2016

ferventcoder commented Dec 16, 2016

6opuc commented Dec 16, 2016

ferventcoder commented Dec 16, 2016

6opuc commented Dec 19, 2016

billw2012 commented Apr 12, 2018 • edited Loading

ferventcoder commented Apr 12, 2018

tpidor commented Dec 11, 2018

oldium commented May 8, 2020

choco-bot commented Mar 14, 2023

6opuc commented Dec 16, 2016 •

edited

Loading

billw2012 commented Apr 12, 2018 •

edited

Loading