Exit when reboot is detected - w/350 for pending & w/1604 on dependency package requiring reboot #1038

Apteryx0 · 2016-11-03T21:34:31Z

As per https://groups.google.com/forum/#!topic/chocolatey/jP4cv8TDUcU, it's probably a good idea to add a switch so that install/upgrade will halt if a dependency requires a reboot. For example, I have a package that has a dependency on PowerShell 3+ - chocolately installed PowerShell v5 but then logged this and then continued to install packages with PowerShell 2 (and subsequently failed):

2016-11-02 12:05:55,829 [INFO ] - PowerShell.5.0 has been installed.
2016-11-02 12:05:55,829 [INFO ] -
2016-11-02 12:05:55,844 [WARN ] - WARNING: PowerShell.5.0 requires a reboot to complete the installation.
2016-11-02 12:05:55,844 [DEBUG] - Built-in PowerShell host called with ['[System.Threading.Thread]::CurrentThread.CurrentCulture = '';[System.Threading.Thread]::CurrentThread.CurrentUICulture = ''; & import-module -name 'C:\ProgramData\chocolatey\helpers\chocolateyInstaller.psm1'; & 'C:\ProgramData\chocolatey\helpers\chocolateyScriptRunner.ps1' -packageScript 'C:\ProgramData\chocolatey\lib\PowerShell\tools\ChocolateyInstall.ps1' -installArguments '' -packageParameters '''] exited with '3010'.
2016-11-02 12:05:55,844 [DEBUG] - Calling command ['"C:\Windows\System32\shutdown.exe" /a']
2016-11-02 12:05:55,870 [DEBUG] - Command ['"C:\Windows\System32\shutdown.exe" /a'] exited with '1116'

ferventcoder · 2016-11-03T21:35:44Z

Thanks!

Release Notes

To turn on this feature, please run choco feature enable --name="'exitOnRebootDetected'"

When Package Exit codes are turned on (#512), we'll exit indicating reboot necessary but not complete:

Pending Reboot discovered prior to running - 350 (ERROR_FAIL_NOACTION_REBOOT - "No action was taken as a system reboot is required.")
Some work completed - 1604 (ERROR_INSTALL_SUSPEND - "Installation suspended, incomplete.")

Both mean reboot and then run again.

jberezanski · 2016-11-04T07:25:17Z

Similar to #913, would probably share most of the implementation.

ferventcoder · 2019-03-04T16:05:53Z

When finding a pending reboot before doing anything, we will fail with 350 - https://docs.microsoft.com/en-us/windows/desktop/debug/system-error-codes--0-499-

ERROR_FAIL_NOACTION_REBOOT

350 (0x15E)

No action was taken as a system reboot is required.

ferventcoder · 2019-03-04T16:07:56Z

Currently we are looking for what exit code to use when we've installed some dependencies, but have not installed everything because there is a reboot required in the middle. We've come to 3011, 3017, and a couple of others, but none are ideal in the definition.

https://docs.microsoft.com/en-us/windows/desktop/debug/system-error-codes--1700-3999-

ERROR_SUCCESS_REBOOT_REQUIRED

3010 (0xBC2)

The requested operation is successful. Changes will not be effective until the system is rebooted.

ERROR_SUCCESS_RESTART_REQUIRED

3011 (0xBC3)

The requested operation is successful. Changes will not be effective until the service is restarted.

ERROR_FAIL_REBOOT_REQUIRED

3017 (0xBC9)

The requested operation failed. A system reboot is required to roll back changes made.

ERROR_FAIL_REBOOT_INITIATED

3018 (0xBCA)

The requested operation failed. A system reboot has been initiated to roll back changes made.

ferventcoder · 2019-03-04T16:11:17Z

1602 could be an option, but it could also be indicative of other areas where a user cancels the install.

ferventcoder · 2019-03-04T16:16:24Z

https://docs.microsoft.com/en-us/windows/desktop/debug/system-error-codes--1300-1699-

ERROR_INSTALL_USEREXIT

1602 (0x642)

User cancelled installation.

ERROR_INSTALL_FAILURE

1603 (0x643)

Fatal error during installation.

ERROR_INSTALL_SUSPEND

1604 (0x644)

Installation suspended, incomplete.

ferventcoder · 2019-03-04T16:17:20Z

1604 looks like a Winner here

AdmiringWorm · 2019-03-04T16:17:28Z

@ferventcoder what about error code 350?
https://docs.microsoft.com/en-us/windows/desktop/debug/system-error-codes--0-499-#ERROR_FAIL_NOACTION_REBOOT

ferventcoder · 2019-03-04T16:18:08Z

See above, we've already identified 350

AdmiringWorm · 2019-03-04T16:18:30Z

Sorry, I missed that one.

ferventcoder · 2019-03-04T16:20:32Z

No worries. We have identified two codes - 350 for exit without doing anything, and 1604 for exit if some work has been completed, but not finished. Both mean reboot and then run again.

ferventcoder · 2019-03-04T16:23:49Z

Updated #1038 (comment) above

There is now both a parameter and a feature flag which will allow halting the install/upgrade/uninstall of a package, when a reboot request is returned from one of it's dependencies. When this occurs, an ApplicationException will be thrown, and the package exit code, either 1641 (restart initiated), or 3010 (restart requested) will be returned. This could then be inspected to decide when a reboot should actually be performed, before continuing with the remainder of the installation. The implementation of this ability followed closely to how the stoponfirstfailure parameter and feature flag are implemented.

There are now parameters and a feature flag which will allow halting/overriding the install/upgrade/uninstall of a package, when a reboot request is returned from one of it's dependencies. When this occurs, an ApplicationException will be thrown, along with a specific exit code, either 350 (pending reboot discovered prior to running), or 1604 (some work completed prior to restart request) will be returned. This could then be inspected to decide when a reboot should actually be performed, before continuing with the remainder of the installation. The initial implementation of this ability followed closely to how the stoponfirstfailure parameter and feature flag are implemented, and then subsequent changes added to the implementation.

When executing Chocolatey commands, it is well known that a pending reboot requirement can prevent a succesful operation. This adds the ability to enable detection of a pending reboot (implemented as a global validation), which will then halt execution of the command. This addition doesn't require that the usePackageExitCodes feature be enabled, but rather, it inspecting the current state of the system, via the registry to determine if a reboot is required. These checks will only be performed when running on the Windows Operating System.

There are now parameters and a feature flag which will allow halting/overriding the install/upgrade/uninstall of a package, when a reboot request is returned from one of it's dependencies. When this occurs, an ApplicationException will be thrown, along with a specific exit code, either 350 (pending reboot discovered prior to running), or 1604 (some work completed prior to restart request) will be returned. This could then be inspected to decide when a reboot should actually be performed, before continuing with the remainder of the installation.

When executing Chocolatey commands, it is well known that a pending reboot requirement can prevent a succesful operation. This adds the ability to enable detection of a pending reboot (implemented as a global validation), which will then halt execution of the command. This addition doesn't require that the usePackageExitCodes feature be enabled, but rather, it inspecting the current state of the system, via the registry to determine if a reboot is required. These checks will only be performed when running on the Windows Operating System.

There are now parameters and a feature flag which will allow halting/overriding the install/upgrade/uninstall of a package, when a reboot request is returned from one of it's dependencies. When this occurs, an ApplicationException will be thrown, along with a specific exit code, either 350 (pending reboot discovered prior to running), or 1604 (some work completed prior to restart request) will be returned. This could then be inspected to decide when a reboot should actually be performed, before continuing with the remainder of the installation.

When executing Chocolatey commands, it is well known that a pending reboot requirement can prevent a succesful operation. This adds the ability to enable detection of a pending reboot (implemented as a global validation), which will then halt execution of the command. This addition doesn't require that the usePackageExitCodes feature be enabled, but rather, it inspecting the current state of the system, via the registry to determine if a reboot is required. These checks will only be performed when running on the Windows Operating System.

There are now parameters and a feature flag which will allow halting/overriding the install/upgrade/uninstall of a package, when a reboot request is returned from one of it's dependencies. When this occurs, an ApplicationException will be thrown, along with a specific exit code, either 350 (pending reboot discovered prior to running), or 1604 (some work completed prior to restart request) will be returned. This could then be inspected to decide when a reboot should actually be performed, before continuing with the remainder of the installation.

* stable: (GH-1655) make virtual methods for outdated / package service (GH-1747) Fix: passing timeout switch of 0 is ignored (GH-1746) Update XML comments / formatting (GH-1746) update logging for validation (GH-1038) Stop operation on package reboot request (GH-1038) Stop execution if pending reboot (GH-1746) Add concept of global validation (maint) Corrected white space

ferventcoder · 2019-03-11T18:43:15Z

This has been completed and will be released with 0.10.12.

For exit on reboot detected, it's actually best to have it on as it makes things more reliable for installations. Remove the note that mentions otherwise.

* stable: (doc) add exit codes to gen doc headings (doc) update generated docs (version) 0.10.12 (doc) fix grammar (GH-1038) remove note on off recommendation (GH-1746) allow shutting off validation warnings (doc) update release notes for licensed extension (maint) whitespace (doc) update release notes (maint) formatting (GH-1758)(doc) provide exit code docs (doc) info - add usage / examples (doc) outdated - note ignore unfound (doc) scripting - point to scripting reference (doc) scripting - how to get exit code w/powershell (GH-1724) search - exit 2 on no results (GH-1758) control enhanced exit codes w/feature (doc) update release notes for 0.10.12 release (doc) update older release notes

ferventcoder changed the title ~~Contribution suggestion: switch to halt install if dependency requires a reboot~~ Feature/switch to halt install if dependency requires a reboot Nov 3, 2016

ferventcoder added Improvement Up For Grabs 0 - Backlog labels Nov 3, 2016

ferventcoder added this to the 0.10.x milestone Nov 3, 2016

jberezanski mentioned this issue Nov 9, 2018

tools,win: refactor install_tools.bat nodejs/node#24113

Closed

4 tasks

ferventcoder modified the milestones: 0.10.x, 0.10.12 Feb 12, 2019

ferventcoder added Priority_HIGH and removed Up For Grabs labels Feb 12, 2019

ferventcoder self-assigned this Feb 12, 2019

ferventcoder added 1 - Ready and removed 0 - Backlog labels Mar 1, 2019

gep13 self-assigned this Mar 4, 2019

gep13 added 2 - Working and removed 1 - Ready labels Mar 4, 2019

gep13 mentioned this issue Mar 5, 2019

(GH-1038) Halt operation if there is a pending reboot already existing, or from package dependency #1742

Closed

ferventcoder added 4 - Done and removed 2 - Working labels Mar 11, 2019

ferventcoder closed this as completed Mar 11, 2019

ferventcoder changed the title ~~Feature/switch to halt install if dependency requires a reboot~~ Halt install if dependency requires a reboot Mar 13, 2019

ferventcoder changed the title ~~Halt install if dependency requires a reboot~~ Exit 350/1602 when a reboot is detected - 350 (pending) / 1602 (based on dependency package) Mar 14, 2019

ferventcoder changed the title ~~Exit 350/1602 when a reboot is detected - 350 (pending) / 1602 (based on dependency package)~~ Exit when a reboot is detected - w/350 for pending & w/1602 on dependency package requiring reboot Mar 14, 2019

ferventcoder changed the title ~~Exit when a reboot is detected - w/350 for pending & w/1602 on dependency package requiring reboot~~ Exit when reboot is detected - w/350 for pending & w/1602 on dependency package requiring reboot Mar 14, 2019

ferventcoder changed the title ~~Exit when reboot is detected - w/350 for pending & w/1602 on dependency package requiring reboot~~ Exit when reboot is detected - w/350 for pending & w/1604 on dependency package requiring reboot Mar 14, 2019

ferventcoder added a commit that referenced this issue Mar 15, 2019

(GH-1038) remove note on off recommendation

a9f3284

For exit on reboot detected, it's actually best to have it on as it makes things more reliable for installations. Remove the note that mentions otherwise.

ferventcoder mentioned this issue Mar 17, 2019

Reboot - Pending File Rename Operations check returns true, even after reboot #1768

Closed

gep13 added 5 - Released and removed 4 - Done labels Sep 7, 2021

General-Fault mentioned this issue May 16, 2024

Flag DSC to reboot computer if package returns a reboot code. chocolatey/cChoco#184

Open

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Exit when reboot is detected - w/350 for pending & w/1604 on dependency package requiring reboot #1038

Exit when reboot is detected - w/350 for pending & w/1604 on dependency package requiring reboot #1038

Apteryx0 commented Nov 3, 2016

ferventcoder commented Nov 3, 2016 •

edited

Loading

jberezanski commented Nov 4, 2016

ferventcoder commented Mar 4, 2019

ferventcoder commented Mar 4, 2019

ferventcoder commented Mar 4, 2019

ferventcoder commented Mar 4, 2019

ferventcoder commented Mar 4, 2019

AdmiringWorm commented Mar 4, 2019

ferventcoder commented Mar 4, 2019

AdmiringWorm commented Mar 4, 2019

ferventcoder commented Mar 4, 2019

ferventcoder commented Mar 4, 2019

ferventcoder commented Mar 11, 2019

Exit when reboot is detected - w/350 for pending & w/1604 on dependency package requiring reboot #1038

Exit when reboot is detected - w/350 for pending & w/1604 on dependency package requiring reboot #1038

Comments

Apteryx0 commented Nov 3, 2016

ferventcoder commented Nov 3, 2016 • edited Loading

Release Notes

jberezanski commented Nov 4, 2016

ferventcoder commented Mar 4, 2019

ferventcoder commented Mar 4, 2019

ferventcoder commented Mar 4, 2019

ferventcoder commented Mar 4, 2019

ferventcoder commented Mar 4, 2019

AdmiringWorm commented Mar 4, 2019

ferventcoder commented Mar 4, 2019

AdmiringWorm commented Mar 4, 2019

ferventcoder commented Mar 4, 2019

ferventcoder commented Mar 4, 2019

ferventcoder commented Mar 11, 2019

ferventcoder commented Nov 3, 2016 •

edited

Loading