Skip to content

Commit

Permalink
(#2050) Fix broken integration tests
Browse files Browse the repository at this point in the history
In a previous commit
(fb22630)
a change was made to remove the pinned source dependencies from the
list of available packages only when we are not ignoring pinned
packages.  While this change was valid, it forgot to populate the
removedSources property with the results of the call to
RemovePinnedSourceDependencies.  This was an oversight, and although
the change was tested locally, a complete execution of all the
integration tests was not performed, which would have caught this
problem.
  • Loading branch information
gep13 committed Apr 30, 2024
1 parent b09a214 commit ad6ff57
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/chocolatey/infrastructure.app/services/NugetService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1347,7 +1347,7 @@ public virtual ConcurrentDictionary<string, PackageResult> Upgrade(ChocolateyCon

if (!config.UpgradeCommand.IgnorePinned)
{
RemovePinnedSourceDependencies(sourcePackageDependencyInfos, allLocalPackages);
removedSources.AddRange(RemovePinnedSourceDependencies(sourcePackageDependencyInfos, allLocalPackages));
}

if (version != null || removedSources.Count == 0)
Expand Down

0 comments on commit ad6ff57

Please sign in to comment.