(GH-262) Ensure explicit source proxy bypass

Also ensure that a source only logs bypassing a proxy when configured to skip the proxy.
chocolatey · Mar 1, 2017 · 7f29b62 · 7f29b62
1 parent 569f8fb
commit 7f29b62
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/NuGet-Chocolatey/NuGet.Core.dll b/lib/NuGet-Chocolatey/NuGet.Core.dll
diff --git a/src/chocolatey/infrastructure.app/nuget/NugetCommon.cs b/src/chocolatey/infrastructure.app/nuget/NugetCommon.cs
@@ -78,7 +78,7 @@ public static IPackageRepository GetRemoteRepository(ChocolateyConfiguration con
 
                 if (!string.IsNullOrWhiteSpace(configuration.Proxy.BypassList))
                 {
-                    "chocolatey".Log().Debug("Proxy has a bypass list of {0}");
+                    "chocolatey".Log().Debug("Proxy has a bypass list of '{0}'.");
                     proxy.BypassList = configuration.Proxy.BypassList.Split(new[] { ',' }, StringSplitOptions.RemoveEmptyEntries);
                 }
 
@@ -107,8 +107,8 @@ public static IPackageRepository GetRemoteRepository(ChocolateyConfiguration con
 
                         if (machineSource != null)
                         {
-                            "chocolatey".Log().Debug("Source '{0}' is configured to bypass proxies.".format_with(source));
                             bypassProxy = machineSource.BypassProxy;
+                            if (bypassProxy) "chocolatey".Log().Debug("Source '{0}' is configured to bypass proxies.".format_with(source));
                         }
                     }
                     catch (Exception ex)