Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-77) Push to gallery on new tags #78

Merged

Conversation

ferventcoder
Copy link
Member

@ferventcoder ferventcoder commented Apr 19, 2017

Instead of pushing on merges to master, push to the PowerShell gallery
on new tags being added. We want to use tagging for versioning and
getting to version history in the repository, so it's good to just set
that up appropriately.

Closes #77

Instead of pushing on merges to master, push to the PowerShell gallery
on new tags being added. We want to use tagging for versioning and
getting to version history in the repository, so it's good to just set
that up appropriately.
@ferventcoder
Copy link
Member Author

Probably best to review the second commit as it removes the noise.

Copy link
Contributor

@smurawski smurawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@lawrencegripper lawrencegripper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, worth noting this will push to powershell gallery if a new tag is added to any branch not just master (I think). Not a problem and potentially useful but worth knowing.

@smurawski
Copy link
Contributor

@lawrencegripper tags aren't unique to a branch - they point to a particular commit with a specified history. While we usually tag off master, it's not a requirement. For example, if you have a security fix that you want to publish for a previous major version, you might end up with a new tag not off master.

@ferventcoder ferventcoder merged commit cad8c4d into chocolatey:development Apr 27, 2017
@ferventcoder ferventcoder deleted the ticket/dev/deploy-on-tags branch April 27, 2017 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants