Choco0.10.3

[riezebosch]

Updated the chocolatey lib to 0.10.3.

Things I had to fix:

• Initialisation of the ChocolateyWrapper
• Output of the PsLogger
• Redirect of Verbose messages that (accidentally) were invoked on the Info method

Currently there are still some things up for improvement:

• Duplicate lines in the output, especially warnings (probably related: Duplicate messages in log files #80)

But at least this update fixes a handful of open compatibility issues with newer versions of chocolatey:

• 0.9.10 and exit codes #186
• Chocolatey aborting shutdown causes Boxstarter to report failed install #148
• Probably choco feature enable -n allowEmptyChecksums #198

[ferventcoder]

chocolatey/choco#1121

[ferventcoder]

Hopefully this won't be needed for long - chocolatey/choco#1102

[mwrock]

The unfortunate consequence of using Console is that remote runs of boxstarter lose all output. However, I can see why you went down that route. I've done a fair bit of tinkering myself and something is causing powershell to crash with a stackoverflowexception if you use the powershell host.

[riezebosch]

That's the reason I went for the console. It looks like the writes on PSHostUserInterface are intercepted (by chocolatey I presume) and fed back to the custom logger causing an infinite recursive loop resulting in a stack overflow. But I couldn't figure out where that interception was done and how I could work around it.

[mwrock]

right. the exception occurs on the very first call to write-* by the caller of the choco library after initialization but before calling run on the choco instance. I'm torn between hunting this down in choco and just rewriting boxstarter as its design gets more grotesque every time I look at it. If I could only stop time.

[ferventcoder]

Try with the fixes I implemented and see if it is still an issue. There should be an available build here - https://ci.appveyor.com/project/chocolatey/choco/build/1.0.0.1121/artifacts

[mwrock]

Oh that does indeed address the stackoverflow! Nice @ferventcoder.

[mwrock]

@ferventcoder any eta on when that fix will land in the nuget feed?

[ferventcoder]

Jan/ early Feb is the best estimate.

[mwrock]

cool. I'll keep an eye out.Closing this. Master should be good to go once that releases.

[ferventcoder]

So February is what we are working with now. That date is unlikely to shift.

[wspait]

Hi Folks, is this waiting to be approved by @mwrock to be merged back into Master?

[mwrock]

No master has most of what is necessary. I'm just waiting on the above referenced choco fix to land in the nuget feed and then I can prep a release.

[wspait]

@mwrock Thanks for the response! Once that choco version gets into NuGet, a new Boxstarter version is planned for release sometime thereafter?

[mwrock]

correct!