(#46) Fix issues when lock files are attempted to be written in restricted directories #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A couple of places in the package extractor we incorrectly uses the target nupkg as the basis of where to store any lock files that are related to these files. This causes an issue due to the lock files being created in the same directory that NuGet.Client removes all files from before downloading the nupkg file, and causes a unauthorized exception. Instead, this commit changes it to use the target path that will be set to the directory instead, which causes the lock files to be created in its parent directory.
In some rare cases the use of the BasePath property to store the original location before overriding it will throw an exception when this original location is not writable by the current process. Instead, this commit changes to store the value directly from the field with a similar name instead to prevent these exceptions from occuring in these cases.
gep13
deleted the
46-process-denied-when-deleting-lock-files-for-package-installs
branch
|
@AdmiringWorm thanks for getting this fixed up! |
5 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
THe changes in this PR are related to the changes that was made in 3.4.1.
Among these changes it corrects the location to write lock files to when a package gets extracted. It was incorrectly using the directory of a nupkg file, which caused issues when the file gets downloaded to this location as NuGet.Client attempts to clean out the directory first, which would cause a process denied exception due to the lock file being there.
Additionally, the use of the BasePath in the ConcurrentUtility has also been fixed by not using the Property that may cause an exception to occur when it is set to a restricted directory, and instead use the field that have no additional logic behind it.
Motivation and Context
To fix non-admins not being able download packages, and to fix the bug in 3.4.1 that causes certain installation operations to fail due to the incorrect folder being used for lock files.
Testing
choco config set cacheLocation "$env:ChocolateyInstall\choco-cache"choco install pester --version 5.3.0(or a lower version if 5.3.0 is latest on your sources)choco upgrade pesterchoco uninstall pester$env:ChocolateyInstall\choco-cache\ChocolateyScratchchoco dowload pester --version 5.3.0(or a lower version if 5.3.0 is latest on your sources)choco download pester --forceOperating Systems Testing
Change Types Made
Change Checklist
Related Issue
Fixes #46