-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nuspec - Add .NET Framework 4.x Dependency [Customer] #632
Comments
<dependency id="dotnetfx" version="4.5.2.0" />
|
The only thing I don't like here is that if someone does NOT want to upgrade to a newer .NET framework dependency, this will do so. Perhaps a second set of packages that are specific to ensuring a minimum version or doing nothing. |
@jberezanski This goes back to why I said a single .NET Framework package needs more discussion. I want to specify a minimum version dependency and NOOP if it is met. That is not possible with what has been done with the dotnetfx package because by design However, it's not as simple as saying I can specify an exact version dependency on the dotnetfx package either. I potentially block other valid and compatible installations If I add it like this:
Really the best route is to mix what you have done with $release = 379893
$version = '4.5.2'
$productNameWithVersion = "Microsoft .NET Framework $version"
$url = 'https://download.microsoft.com/download/E/2/1/E21644B5-2DF2-47C2-91BD-63C560427900/NDP452-KB2901907-x86-x64-AllOS-ENU.exe'
$checksum = '6C2C589132E830A185C5F40F82042BEE3022E721A216680BD9B3995BA86F3781'
$checksumType = 'sha256'
if (Test-Installed -Release $release) {
Write-Host "$productNameWithVersion or later is already installed."
return
} Into several packages that are a bit more official. And add a package parameter that would allow someone to force that particular version to be installed, even if there is a newer version. That way you get the best of both worlds. Thoughts? |
I should say the constraints are felt most often by organizations and not necessarily individuals. We have both types of users on the community repo. |
I should note for other folks who find there way here, I did not raise an issue at https://github.com/jberezanski/ChocolateyPackages/issues because by design there isn't any change to the dotnetfx package I can suggest at the moment. It's a partial solution - it meets the case where folks are fine with getting the latest .NET version when they install something. |
@FranklinYu I have added the suggested dependency. This currently fails installation during package installation on the local test environment do to dependency requiring a reboot, so an exemption will be required for moderation process. This may require some changes based on some potential work/changes to dotnet packages on chocolatey.org, but that can be revisited at a later date. |
🎉 This issue has been resolved in version 0.17.0 🎉 The release is available on: Your GitReleaseManager bot 📦🚀 |
The description says
I hereby propose to add
DotNet4.5.2
to dependency list. #40 is related, but that is about .NET 4.0.Moved from Disqus comment.
The text was updated successfully, but these errors were encountered: