Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Configuration - Seeing and Setting Bypass Proxy and Allow Self-Service on a Source doesn't work #455

Closed
ferventcoder opened this issue Jul 12, 2017 · 9 comments
Assignees
Labels
Bug Issues where something has happened which was not expected or intended
Milestone

Comments

@ferventcoder
Copy link
Member

This is not pulling the data properly, nor is it setting it. Something is not getting set correctly in the binding to make this setting take. I am somewhat limited on WPF to see what it may be.

@ferventcoder ferventcoder added :Chocolatey Bug Issues where something has happened which was not expected or intended labels Jul 12, 2017
@ferventcoder ferventcoder added this to the 0.15.0 milestone Jul 12, 2017
@ferventcoder
Copy link
Member Author

ferventcoder commented Jul 12, 2017

I did add this to the mapper configuration (AutoMapper) as the names are different:

config.CreateMap<ConfigFileSourceSetting, ChocolateySource>()
    .ForMember(dest => dest.ByPassProxy, opt => opt.MapFrom(src => src.BypassProxy))
    .ForMember(dest => dest.SelfService, opt => opt.MapFrom(src => src.AllowSelfService));

I'm not sure if the mapper configuration setup pulls things back correctly though.

@RichiCoder1
Copy link
Contributor

Derp. Proper solution would like be to simply change the ChocolateySource properties.

@RichiCoder1 RichiCoder1 self-assigned this Jul 13, 2017
@ferventcoder
Copy link
Member Author

To match the ConfigSettings? Yeah, likely to work best.

@ferventcoder
Copy link
Member Author

The following affects this fix - chocolatey/choco#1394

ferventcoder added a commit to ferventcoder/ChocolateyGUI that referenced this issue Aug 29, 2017
Instead of adding a map, ensure that the source name properties for
bypass proxy and allow self service match the name in
`ConfigFileSourceSettings`.
@gep13 gep13 closed this as completed in #459 Sep 6, 2017
gep13 added a commit that referenced this issue Sep 6, 2017
(GH-455)(GH-432) Sources updates / Chocolatey 0.10.8 updates
@ferventcoder
Copy link
Member Author

Are we sure this is fixed?

@gep13
Copy link
Member

gep13 commented Sep 6, 2017

@ferventcoder this ticket was closed automagically as a result of the comment in your PR.

I tried to test it out at lunch time, however, I was running into other issues. You around tonight for a quick conversation?

@ferventcoder ferventcoder reopened this Sep 6, 2017
@ferventcoder
Copy link
Member Author

Yes sir. Just ping me when you are ready.

@gep13
Copy link
Member

gep13 commented Sep 6, 2017

@ferventcoder yeah, just tested this, and no, it still isn't working 😢

gep13 added a commit that referenced this issue Sep 6, 2017
- These are required to ensure correct serialization and de-serialization between ChocolateyGUI and the SubProcess
@gep13
Copy link
Member

gep13 commented Sep 6, 2017

@ferventcoder as discussed, this should now be taken care of, and the latest version on MyGet (0.14.0-unstable0299) should include this functionality.

@gep13 gep13 closed this as completed Sep 6, 2017
@gep13 gep13 removed the :Chocolatey label Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues where something has happened which was not expected or intended
Projects
None yet
Development

No branches or pull requests

3 participants