-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Configuration - Seeing and Setting Bypass Proxy and Allow Self-Service on a Source doesn't work #455
Comments
I did add this to the mapper configuration (AutoMapper) as the names are different: config.CreateMap<ConfigFileSourceSetting, ChocolateySource>()
.ForMember(dest => dest.ByPassProxy, opt => opt.MapFrom(src => src.BypassProxy))
.ForMember(dest => dest.SelfService, opt => opt.MapFrom(src => src.AllowSelfService)); I'm not sure if the mapper configuration setup pulls things back correctly though. |
Derp. Proper solution would like be to simply change the |
To match the ConfigSettings? Yeah, likely to work best. |
The following affects this fix - chocolatey/choco#1394 |
Instead of adding a map, ensure that the source name properties for bypass proxy and allow self service match the name in `ConfigFileSourceSettings`.
Are we sure this is fixed? |
@ferventcoder this ticket was closed automagically as a result of the comment in your PR. I tried to test it out at lunch time, however, I was running into other issues. You around tonight for a quick conversation? |
Yes sir. Just ping me when you are ready. |
@ferventcoder yeah, just tested this, and no, it still isn't working 😢 |
- These are required to ensure correct serialization and de-serialization between ChocolateyGUI and the SubProcess
@ferventcoder as discussed, this should now be taken care of, and the latest version on MyGet ( |
This is not pulling the data properly, nor is it setting it. Something is not getting set correctly in the binding to make this setting take. I am somewhat limited on WPF to see what it may be.
The text was updated successfully, but these errors were encountered: