(#155) Keep directory structure for signed PowerShell scripts #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates how scripts that are signed will be handled, by using the same directory structure in the output folder as is relative for the now new parameter for a Root Folder. This allows multiple files to be signed that have the same name, without them replacing eachother.
This updates the signing process of PowerShell scripts, to instead of uploading them as artifacts in an uncompressed way that requires downloading multiple files, we instead create a zip archive of the scripts while preserving the directory structure where the files came from. This allows it to be easier in the future when changes have been made, and we only need to extract a single archive without having to manually figure out where the files need to be located.
|
@AdmiringWorm thanks for getting this fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This updates how scripts that are signed will be handled, by using the
same directory structure in the output folder as is relative for the now
new parameter for a Root Folder. It also updates how the artifacts are created and uploaded by first create a zip archive of the files hile preserving the directory structure, and then upload only the zip archive.
Motivation and Context
To allow multiple files with the same name to be signed, without the files overwriting eachother, as well as making it easier in the future when we have signed scripts and only need to download a single file that can be extracted immediately to the correct locations.
Testing
This has been tested manually by running the signing process locally, while commenting out the necessary parts that would fail if no signing keys are present.
The verification was that everything was copied to the correct directory structure, a zip archive was created with the same directory structure expected and it uploaded it to the artifacts directory.
Operating Systems Testing
Change Types Made
Change Checklist
Related Issue
Fixes #155