(#145) Enable skipping of Yarn analysis #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windos
force-pushed
the
GH-145/skip-dependencycheck-yarn-analysis
branch
from
8322650 to
8ef9fec
Compare
During the Dependency-Check task, the Yarn Audit analysis can be triggered even when it is not needed. This results in the task, and build, failing. By adding a new tool setting, DependencyCheckDisableYarnAudit, the Yarn Audit analysis can be explicitly disabled when required. This new parameter defaults to `false`. This change should be revisited when Cake.DependencyCheck and DependencyCheckTool are updated.
Windos
force-pushed
the
GH-145/skip-dependencycheck-yarn-analysis
branch
from
8ef9fec to
3ca5aec
Compare
|
@gep13 - Thanks for your input on this PR, I swapped over to Tool Settings for my change. I also got this change tested today, it highlighted that the path to the batch file needed an explicit |
|
@Windos this looks great! Happy to get this merged in, and get a new release out the door! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This PR enables disabling the Dependency-Check Yarn Audit analysis as part of the Dependency-Check task. Due to the Dependency-Check Cake addin being out of date, this is achieved by injecting the required switch into the
dependency-check.batwhen a new tool setting, dependencyCheckDisableYarnAudit, is set totrue.Motivation and Context
Dependency-Check occasionally triggers Yarn analysis when it isn't needed and results in the Dependency-Check failing. By disabling this analysis, it allows the Dependency-Check, and build in general, to complete successfully.
Testing
.\build.bat --verbosity=diagnostic --target=CI --testExecutionType=none --shouldRunAnalyze=false --shouldRunIlMerge=false --shouldObfuscateOutputAssemblies=false --shouldRunChocolatey=false --shouldRunNuGet=false --shouldRunSonarQube=true --shouldRunDependencyCheck=true--dependencyCheckDisableYarnAudit=trueOperating Systems Testing
Windows Server 2019
Change Types Made
Change Checklist
Related Issue