Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary setting of TeamCIty parameter for CCM Build Version #69

Closed
corbob opened this issue Jul 5, 2022 · 2 comments · Fixed by #70
Closed

Remove unnecessary setting of TeamCIty parameter for CCM Build Version #69

corbob opened this issue Jul 5, 2022 · 2 comments · Fixed by #70
Assignees
@corbob
Labels
Improvement Issues that enhances existing functionality, or adds new features
Milestone
0.15.0

Comments

@corbob
Copy link
Member

corbob commented Jul 5, 2022

Is Your Feature Request Related To A Problem? Please describe.

On old TeamCity, CCM builds stamped a parameter named CCMVersion. The recipe explicitly does this with a check of the build title. It would be good to stamp a pre-agreed parameter (perhaps just Version) with this for all builds.

Describe The Solution. Why is it needed?

Test Kitchen can be told to build against a specific version. The builds ideally can chain off of each other and test specific explicit builds.

Additional Context.

Encountered this when working on moving from old TeamCity to new TeamCity

Related Issues

N/A
@corbob
Copy link
Member Author

corbob commented Jul 6, 2022

Ok, We don't actually need to put it into a different parameter. We already stamp build.number and I've confirmed we can use that in chained builds 😁

corbob added a commit to corbob/Chocolatey.Cake.Recipe that referenced this issue Jul 6, 2022
@corbob
(chocolatey#69) Remove stamp of CCMVersion TeamCity param
11d039a 
We don't need to set the CCMVersion because we're able to pull it from
the build.number parameter that is already set.
@corbob corbob mentioned this issue Jul 6, 2022
Merged
8 tasks
gep13 pushed a commit to corbob/Chocolatey.Cake.Recipe that referenced this issue Jul 13, 2022
@corbob @gep13
(chocolatey#69) Remove stamp of CCMVersion TeamCity param
09d1df6 
We don't need to set the CCMVersion because we're able to pull it from
the build.number parameter that is already set.
@gep13 gep13 added this to the 0.15.0 milestone Jul 13, 2022
@gep13 gep13 added the Improvement Issues that enhances existing functionality, or adds new features label Jul 13, 2022
@gep13 gep13 changed the title Should output a TeamCity version number for all builds Remove unnecessary setting of TeamCIty parameter for CCM Build Version Jul 13, 2022
@gep13 gep13 closed this as completed in #70 Jul 13, 2022
gep13 added a commit that referenced this issue Jul 13, 2022
@gep13
Merge pull request #70 from corbob/remove-ccmversion-stamp
1015897 
(#69) Remove stamp of CCMVersion TeamCity parameter
gep13 added a commit that referenced this issue Jul 13, 2022
@gep13
Merge branch 'release/0.15.0'
1089f48 
* release/0.15.0:
  (#69) Remove stamp of CCMVersion TeamCity param
  (#67) Reset eazfuscator settings each iteration
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.15.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corbob corbob

Labels
Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

(#69) Remove stamp of CCMVersion TeamCity parameter corbob/Chocolatey.Cake.Recipe
3 participants
@gep13 @choco-bot @corbob