Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix path used in AssemblyKeyFile attribute #36

Closed
gep13 opened this issue Apr 30, 2022 · 1 comment
Closed

Fix path used in AssemblyKeyFile attribute #36

gep13 opened this issue Apr 30, 2022 · 1 comment
Assignees
@gep13
Labels
Bug Issues where something has happened which was not expected or intended
Milestone
0.5.1

Comments

@gep13
Copy link
Member

gep13 commented Apr 30, 2022

During the generation of the SolutionVersion.cs file on a non Windows machine, the generated path uses backslashes, when it should be using forward slashes.

This causes the build to fail, since the file can't be found.
@gep13 gep13 added the Bug Issues where something has happened which was not expected or intended label Apr 30, 2022
@gep13 gep13 added this to the 0.5.1 milestone Apr 30, 2022
@gep13 gep13 self-assigned this Apr 30, 2022
@gep13 gep13 closed this as completed May 2, 2022
gep13 added a commit that referenced this issue May 2, 2022
@gep13
(#36) Remove replacement of forward slash
afdfde8 
When adding a path to the assemblyinfo.cs file, the backslashes need to
be escaped, otherwise, it causes errors. However, there was also a
replacement of valid forward slashes (which are used on POSIX systems).
This problem only showed up once we started building the
chocolatey/choco repository on GitHub Actions across multiple different
operating systems.
gep13 added a commit that referenced this issue May 2, 2022
@gep13
Merge branch 'hotfix/0.5.1'
003d843 
* hotfix/0.5.1:
  (#37) Further shorten the package version
  (#36) Remove replacement of forward slash
gep13 added a commit that referenced this issue May 2, 2022
@gep13
Merge branch 'master' into develop
24f69ed 
* master:
  (#37) Further shorten the package version
  (#36) Remove replacement of forward slash
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.5.1 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
Bug Issues where something has happened which was not expected or intended
Projects
None yet
Milestone
0.5.1
Development

No branches or pull requests
2 participants
@gep13 @choco-bot