Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be consistent about when tasks are run #35

Closed
gep13 opened this issue Apr 29, 2022 · 1 comment
Closed

Be consistent about when tasks are run #35

gep13 opened this issue Apr 29, 2022 · 1 comment
Assignees
@gep13
Labels
Improvement Issues that enhances existing functionality, or adds new features
Milestone
0.5.0

Comments

@gep13
Copy link
Member

gep13 commented Apr 29, 2022

Currently, when running an "official" build, the unit test tasks are skipped. However, other related tasks are not skipped, which causes confusion about what is going on.

When skipping tasks, we should consistently skip all related tasks, or not skip them at all.
@gep13 gep13 added the Improvement Issues that enhances existing functionality, or adds new features label Apr 29, 2022
@gep13 gep13 added this to the 0.5.0 milestone Apr 29, 2022
@gep13 gep13 self-assigned this Apr 29, 2022
gep13 added a commit that referenced this issue Apr 29, 2022
@gep13
(#35) Be consistent about skipped tasks
b85a93d 
If we are going to skip one unit testing task if we are running an
official build, we should be consistent and skip all the related
tasks.

At some point, we might want to re-think the concept of skipping these
tasks, but for now, consistency is better than anything else.
@gep13 gep13 closed this as completed Apr 29, 2022
gep13 added a commit that referenced this issue Apr 29, 2022
@gep13
Merge branch 'release/0.5.0'
a132b22 
* release/0.5.0:
  (#34) Add support for ILMerge'ing
  (#35) Be consistent about skipped tasks
  (#33) Truncate prerelease label
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.5.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
2 participants
@gep13 @choco-bot