Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't attempt to push pre-release packages on a tagged build #30

Closed
gep13 opened this issue Mar 17, 2022 · 1 comment
Closed

Don't attempt to push pre-release packages on a tagged build #30

gep13 opened this issue Mar 17, 2022 · 1 comment
Assignees
@gep13
Labels
Bug Issues where something has happened which was not expected or intended
Milestone
0.4.2

Comments

@gep13
Copy link
Member

gep13 commented Mar 17, 2022

Chocolatey.Cake.Recipe has the concept of pushing to:

  • pre-release source
  • release source

Since these sources can actually be the same destination, we don't want to push the same package version twice, as this will cause an error.

As such, since the release source is only intended to be used when we are running a tagged build, make sure to not push to the pre-release source when it is a tagged build. i.e. the sources should be mutually exclusive.
@gep13 gep13 added the Bug Issues where something has happened which was not expected or intended label Mar 17, 2022
@gep13 gep13 added this to the 0.4.2 milestone Mar 17, 2022
@gep13 gep13 self-assigned this Mar 17, 2022
@gep13 gep13 closed this as completed Mar 17, 2022
gep13 added a commit that referenced this issue Mar 17, 2022
@gep13
(#30) Don't duplicate pushing of packages
4e95876 
Make the pushing of pre-release and release packages mutually
exclusive, to prevent the same package being pushed to the same feed
(when they are configured to be the same) thus causing an error.

In addition, add a criteria to both the creation of Chocolatey and
NuGet packages to allow preventing of even attempting to run these
tasks when switched off at the highest level.  This is similar to what
is done with the ShouldRunDotNetCorePack parameter.
gep13 added a commit that referenced this issue Mar 17, 2022
@gep13
Merge branch 'hotfix/0.4.2'
40d0e21 
* hotfix/0.4.2:
  (#30) Don't duplicate pushing of packages
gep13 added a commit that referenced this issue Mar 17, 2022
@gep13
Merge branch 'hotfix/0.4.2' into develop
97c99dd 
* hotfix/0.4.2:
  (#30) Don't duplicate pushing of packages
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.4.2 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
Bug Issues where something has happened which was not expected or intended
Projects
None yet
Milestone
0.4.2
Development

No branches or pull requests
2 participants
@gep13 @choco-bot