Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PowerShell Scripts are not verified when on develop branch #154

Closed
6 tasks done
gep13 opened this issue May 17, 2024 · 1 comment
Closed
6 tasks done

PowerShell Scripts are not verified when on develop branch #154

gep13 opened this issue May 17, 2024 · 1 comment
Assignees
@gep13
Labels
5 - Released The issue has been resolved, and released to the public for consumption Bug Issues where something has happened which was not expected or intended
Milestone
0.28.3

Comments

@gep13
Copy link
Member

gep13 commented May 17, 2024

Checklist

  • I confirm there are no unresolved issues reported on the Chocolatey Status page.
  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my problem.
  • I have verified this is not an issue for a specific package.
  • I have verified this issue is not security related.
  • I confirm I am using official, and not unofficial, or modified, Chocolatey products.

What You Are Seeing?

PowerShell script verification is not running when a build is happening on the develop branch.

What is Expected?

When a build is happening on a 'main' branch, i.e master, develop, release, hotfix, or support, the PowerShell scripts should be verified, and the build fail if one of them isn't valid.

This will mean that once merged into a branch, the scripts will be immediately verified, and if there is a problem, it can be resolved.

How Did You Get This To Happen?

After adding Chocolatey.Cake.Recipe 0.28.2 into the chocolatey/choco repository, the expectation was that it would fail the build since the PowerShell scripts are not signed, but this didn't happen.

System Details

N/A

Installed Packages

N/A

Output Log

N/A

Additional Context

N/A
@gep13 gep13 added the Bug Issues where something has happened which was not expected or intended label May 17, 2024
@gep13 gep13 added this to the 0.28.3 milestone May 17, 2024
@gep13 gep13 self-assigned this May 17, 2024
@gep13 gep13 added the 4 - Done Code has been added to the repository, and has been reviewed by a team member label May 17, 2024
@gep13 gep13 closed this as completed May 17, 2024
gep13 added a commit that referenced this issue May 17, 2024
@gep13
(#154) Verify PowerShell scripts on develop branch
ae80816 
In the previous release, a change was made to try to control "when" the
verification of PowerShell scripts would be completed.  This change
neglected to allow running of this task on the develop branch, and
instead only ran on "releaseable" branches, namely master, hotfix and
release.  To allow catching of PowerShell scripts that haven't been
signed, we need to run the verification task on all "main" branches, i.e.
master, develop, release, hotfix and support.  In other words, any
branches that a PR can be merged into.

This commit fixes the criteria for this to be in place, and also adds
the concept of Support branches to the BranchType enumeration, which
wasn't included previously.
gep13 added a commit that referenced this issue May 17, 2024
@gep13
Merge branch 'hotfix/0.28.3'
7fe3b3d 
* hotfix/0.28.3:
  (#154) Verify PowerShell scripts on develop branch
gep13 added a commit that referenced this issue May 17, 2024
@gep13
Merge branch 'master' into develop
9408060 
* master:
  (#154) Verify PowerShell scripts on develop branch
@gep13 gep13 added 5 - Released The issue has been resolved, and released to the public for consumption and removed 4 - Done Code has been added to the repository, and has been reviewed by a team member labels May 17, 2024
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.28.3 🎉

The release is available on:

Your GitReleaseManager bot 📦 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
5 - Released The issue has been resolved, and released to the public for consumption Bug Issues where something has happened which was not expected or intended
Projects
None yet
Milestone
0.28.3
Development

No branches or pull requests
2 participants
@gep13 @choco-bot