Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSIs should be able to be produced after Chocolatey Packages #103

Closed
2 tasks done
JPRuskin opened this issue Mar 9, 2023 · 1 comment · Fixed by #104
Closed
2 tasks done

MSIs should be able to be produced after Chocolatey Packages #103

JPRuskin opened this issue Mar 9, 2023 · 1 comment · Fixed by #104
Labels
Feature Issues that introduce new functionality to the project, instead of updating existing functionality
Milestone
0.21.0

Comments

@JPRuskin
Copy link
Member

JPRuskin commented Mar 9, 2023

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

When building things that use both an MSI and a Chocolatey Package, as the recipe is currently written there is no way to include the Chocolatey package inside the MSI.

Though this is, arguably, an anti-pattern, it has become a requirement for the Chocolatey MSI.

Describe The Solution. Why is it needed?

We need to be able to produce the MSI after the Chocolatey Package step.

Additional Context

No response

Related Issues

No response
JPRuskin added a commit to JPRuskin/Chocolatey.Cake.Recipe that referenced this issue Mar 9, 2023
@JPRuskin
(chocolatey#103) Adds MsiUsedWithinNupkg
9e7de07 
Defaults to true, as that replicates current behaviour. 

This option, when false, moves the MSI steps to after the creation of the Chocolatey package. This allows for the package to be used within the MSI, rather than the MSI within the package.
JPRuskin added a commit to JPRuskin/Chocolatey.Cake.Recipe that referenced this issue Mar 9, 2023
@JPRuskin
(chocolatey#103) Adds WiX Tool Dependency
54665a1 
Though the only project creating an MSI with these steps  currently has the WiX tool files embedded in source, this was decided to not be ideal for going forward. This change prompts Cake to download the WiX tool files when building an MSI.

3.11.2 was chosen as the version as it's the latest non-prerelease version available on public feeds.
@JPRuskin JPRuskin mentioned this issue Mar 9, 2023
Merged
2 tasks
@gep13 gep13 added this to the 0.21.0 milestone Mar 10, 2023
JPRuskin added a commit to JPRuskin/Chocolatey.Cake.Recipe that referenced this issue Mar 10, 2023
@JPRuskin
(chocolatey#103) Adds MsiUsedWithinNupkg
a443780 
Defaults to true, as that replicates current behaviour. 

This option, when false, moves the MSI steps to after the creation of the Chocolatey package. This allows for the package to be used within the MSI, rather than the MSI within the package.
JPRuskin added a commit to JPRuskin/Chocolatey.Cake.Recipe that referenced this issue Mar 10, 2023
@JPRuskin
(chocolatey#103) Adds WiX Tool Dependency
50e6f26 
Though the only project creating an MSI with these steps  currently has the WiX tool files embedded in source, this was decided to not be ideal for going forward. This change prompts Cake to download the WiX tool files when building an MSI.

3.11.2 was chosen as the version as it's the latest non-prerelease version available on public feeds.
gep13 added a commit that referenced this issue Mar 10, 2023
@gep13
Merge pull request #104 from JPRuskin/addsMsiForking
2915722 
(#103) Adds an option to produce MSIs after the Chocolatey Package
@gep13 gep13 added the Feature Issues that introduce new functionality to the project, instead of updating existing functionality label Mar 10, 2023
gep13 added a commit that referenced this issue Mar 10, 2023
@gep13
Merge branch 'release/0.21.0'
206526a 
* release/0.21.0:
  (#103) Adds WiX Tool Dependency
  (#103) Adds MsiUsedWithinNupkg
  (#98) Adds Optional Docker Steps
  (#96) Adds Optional SonarQube Step
  (maint) Add full stop to each entry
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.21.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Issues that introduce new functionality to the project, instead of updating existing functionality
Projects
None yet
Milestone
0.21.0
Development

Successfully merging a pull request may close this issue.

(#103) Adds an option to produce MSIs after the Chocolatey Package JPRuskin/Chocolatey.Cake.Recipe
3 participants
@gep13 @JPRuskin @choco-bot