Skip to content

Commit

Permalink
(#153) Skip signing verification on PR build
Browse files Browse the repository at this point in the history
The new verify signing task was running on PR builds, which was causing
the PR build to fail when there were signatures that were invalid.

This stops the flow of doing additional testing on the PR builds, as the
arfifacts would not have been created.

We should skip the verification when running on a PR build (or when on a
non-releaseable branch), that way, the additional task of performing
the re-signing can be completed as a follow up piece of work.
  • Loading branch information
gep13 committed May 16, 2024
1 parent 892c826 commit 7060d97
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Chocolatey.Cake.Recipe/Content/sign.cake
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@

BuildParameters.Tasks.VerifyPowerShellScriptsTask = Task("Verify-PowerShellScripts")
.WithCriteria(() => BuildParameters.BuildAgentOperatingSystem == PlatformFamily.Windows, "Skipping due to not running on Windows")
.WithCriteria(() => !BuildParameters.IsPullRequest, "Skipping because current build is from a Pull Request")
.WithCriteria(() => BuildParameters.BranchType == BranchType.Master || BuildParameters.BranchType == BranchType.Release || BuildParameters.BranchType == BranchType.HotFix, "Skipping because this is not a releasable branch")
.WithCriteria(() => BuildParameters.ShouldVerifyPowerShellScripts, "Skipping since verifying PowerShell scripts has been disabled")
.Does(() =>
{
Expand Down

0 comments on commit 7060d97

Please sign in to comment.