Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate PSSA rules in build and reformat files accordingly #67

Closed
vexx32 opened this issue Aug 31, 2022 · 1 comment · Fixed by #70
Closed

Incorporate PSSA rules in build and reformat files accordingly #67

vexx32 opened this issue Aug 31, 2022 · 1 comment · Fixed by #70
Assignees
@vexx32
Labels
4 - Done Build Automation
Milestone
0.3.0

Comments

@vexx32
Copy link
Member

vexx32 commented Aug 31, 2022

Is Your Feature Request Related To A Problem? Please describe.

Code style amongst our repos needs to be consistent.

Describe The Solution. Why is it needed?

  • Incorporate a PSSA run into the build process and fail the build if there are rule violations.
  • Reformat existing code to fix existing rule violations

Additional Context.

We should use the established PSSA rules from chocolatey/Chocolatey.Cake.Recipe#73

Related Issues

N/A
@vexx32 vexx32 added this to the 0.10.0 milestone Aug 31, 2022
@vexx32 vexx32 self-assigned this Aug 31, 2022
vexx32 added a commit to vexx32/ChocoCCM that referenced this issue Aug 31, 2022
@vexx32
(chocolatey#67) Add PSSA linting to the repo
80d6bd2 
Initial pass for formatting existing scripts and adding the PSSA options
to the repo for use in VS Code, and later the build process.
@vexx32 vexx32 mentioned this issue Aug 31, 2022
Closed
vexx32 added a commit to vexx32/ChocoCCM that referenced this issue Sep 1, 2022
@vexx32
(chocolatey#67) Add PSSA linting to the repo
cfa2596 
Initial pass for formatting existing scripts and adding the PSSA options
to the repo for use in VS Code, and later the build process.
@vexx32 vexx32 mentioned this issue Sep 2, 2022
Merged
10 tasks
@vexx32 vexx32 modified the milestones: 0.10.0, 0.2.1 Sep 3, 2022
gep13 pushed a commit to vexx32/ChocoCCM that referenced this issue Sep 8, 2022
@vexx32 @gep13
(chocolatey#67) Add PSSA linting to the repo
940b0f4 
Initial pass for formatting existing scripts and adding the PSSA options
to the repo for use in VS Code, and later the build process.
@gep13 gep13 closed this as completed in #70 Sep 8, 2022
@gep13 gep13 added 4 - Done and removed 2 - Working labels Sep 8, 2022
gep13 added a commit that referenced this issue Sep 8, 2022
@gep13
Merge branch 'release/0.3.0'
f4b4d8d 
* release/0.3.0:
  (doc) Updated psd1 with information for release
  (build) Add GitReleaseManager configuration
  (#69) Add TeamCity Kotlin Configuration
  (#69) Use HttpClient for URI validation
  (#69) Remove faulty license check for now
  (#61) Update local testing documentation
  (#69) Fix up doc links and add missing docs
  (maint) Remove PlatyPS docs
  (#69) Replace build with Invoke-Build setup
  (#67) Add PSSA linting to the repo
  (GH-17) Fix typo in filename
@gep13
Copy link
Member

gep13 commented Sep 8, 2022 •
edited
Loading

🎉 This issue has been resolved in version 0.3.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vexx32 vexx32

Labels
4 - Done Build Automation
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

Reimplement build with Invoke-Build vexx32/ChocoCCM
2 participants
@gep13 @vexx32