(iTunes) Update to latest version and fix install errors #527
Conversation
|
@lennartb- thank you for taking the time to update this, however, there would still need to be some work done here before we could merge it in. iTunes is actually currently what we call a ketatin automatic package, and we are in the process of moving these sorts of packages to be AU packages. You have done part of the work to get this package there. Would you be interested in doing the rest? |
|
Sure, are there docs on how to do this? |
|
@lennartb- Ketarin was the old tool used. Now we're in the process to rewrite everything to a new tool (AU). You can find documentationo about it here. There are also quite a few package in this repo which already use AU, which you can use as a sample. And please also check our contribution guidelines. And if you have any specific questions just let us know :) |
|
What happens if there isn't a direct download to the required installer? I poked around the iTunes download page and it seems the URL is constructed via JS. The actual link the permanent, but there is no *.exe file linked (as in the sample au-packages-template project). I look around the existing packages, but those who had an update.ps1 mostly contained fixed links to the installers. I took a look with Fiddler, but I couldn't figure out the actual download request. |
|
@lennartb- if there is no way to automate the update, then this would have to be moved to the manual directory and manually be updated when it becomes out of date. |
|
Maybe someone more savvy with JS can take a look at it then, I (hopefully) can manage the rest, but I'm not much of a web tech guy. |
|
@lennartb- I can add a update script for this before it's merged (I believe I found a way to get the version and urls), if you could update the rest it would be great. |
|
@lennartb- can you also rebase your changes please |
|
@AdmiringWorm Yep, done |
|
I've added the AU update script, updated the install script and the metadata. /cc @gep13 @pascalberger |
automatic/iTunes/iTunes.nuspec
Outdated
| <id>{{PackageName}}</id> | ||
| <version>{{PackageVersion}}</version> | ||
| <title>iTunes</title> | ||
| <id>iTunes</id> |
There was a problem hiding this comment.
ID should be in lowercase (which would also include directory name)
There was a problem hiding this comment.
true, it should.
But until chocolatey/choco#1040 is fixed, it shouldn't be changed for existing packages.
| Install-ChocolateyInstallPackage @packageArgs | ||
| } | ||
|
|
||
| Remove-Item $packageArgs.unzipLocation -Recurse |
* Updated metadata * Updated install script
This fixes the invalid cast exception from Object[] to Version[], adds a link to the 32 bit version and points both 32 and 64 bit to the latest version