Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after chocolatey 0.10.0 release automated deploy fails #96

Closed
wants to merge 1 commit into from

Conversation

anuriq
Copy link

@anuriq anuriq commented Aug 24, 2016

after upgrade to chocolatey 0.10.0 packages with no checksums will ask
for confirmation, which of course breaks automated deployment.
to work around the issue introduce an attribute switched on by default
to pass --allow-empty-checksums to choco executable. later when most
of packages will be updated we can switch off this by default.
more info here: chocolatey/choco#910

for confirmation, which of course breaks automated deployment.
to work around the issue introduce an attribute switched on by default
to pass '--allow-empty-checksums' to choco executable. later when most
of packages will be updated we can switch off this by default.
more info here: chocolatey/choco#910
@mwrock
Copy link
Contributor

mwrock commented Aug 24, 2016

I think the intent of the chocolatey change was to ensure package consumers are aware of potential threats and provide a means of "opting out" via the --allow-empty-checksums flag.

Having the chef cookbook subvert this seems like the wrong direction. You can certainly pass in any flag via the resource using options. If you want to globally enable this flag, you could use a batch or powershell script resource and execute choco feature enable -n allowEmptyChecksums.

@ferventcoder
Copy link
Contributor

ferventcoder commented Aug 24, 2016

I've already made @anuriq aware, but for anyone else that happens in here, the confirmation prompt does not, I repeat, the prompt does NOT in any way break automated deployment.

Chocolatey has a custom PowerShell host that it runs (and it only asks for confirmation when that host is detected). That host is special in that Prompt for confirmation, Read-Host and Prompt for choice do not block the console and work in completely automated scenarios.

In the image, please note "Respond within 30 seconds" - also notice that no answer was provided and how it moved forward with the default selection.

image

This was implemented in 0.9.10.0. See chocolatey/choco#8 and also https://github.com/chocolatey/choco/blob/master/CHANGELOG.md#0910-june-17-2016

@ferventcoder
Copy link
Contributor

@legal90 @Kasen ^^

@ferventcoder
Copy link
Contributor

Now that said, packages that use HTTP without checksums fail to install in 0.10.0. But there are options there.

@anuriq
Copy link
Author

anuriq commented Aug 25, 2016

@mwrock @ferventcoder my intent was to make a quick fix, so that there would be no need to edit existing cookbooks relying on chocolatey. then, when most of the choco packages are updated to include checksum, this fix would be removed. but if this really doesn't fit, then decline the PR. i guess everyone is able to find a workaround.

@mwrock mwrock closed this Aug 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants