Uninstall-ChocolateyPath.ps1

[rchiav]

I was writing the uninstall for a zip file and wanted to make sure the path was cleaned up. Thought I'd write it to be usable by Chocolatey. Reused a lot of Install-ChocolateyPath.ps1 to keep them similar.

[DarwinJS]

I believe the code submitted may accidentally expand unrelated EMBEDDED environment variables in the PATH environment variable and it won't catch targets that are actually EMBEDDED environment variables because this code "$envPath = $env:PATH" retrieves the path where it is already expanded. I'm not sure if Get-EnvironmentVariable and Set-EnvironmentVariable also deal with expanded environment variables

[Environment]::GetEnvironmentVariable("PATH","User_or_Machine") and [Environment]::SetEnvironmentVariable("PATH","User_or_Machine") keep embedded environment variables intact - for [a] removing an embedded environment variable, [b] not touching other embedded environment variables and for both path retrieval and re-write.

I have some code to do this while preserving environment variables.

[DarwinJS]

It's probably self evident - but mucking up the system path on choco machines could bring a lot of rage it's way :( Might be good to review whether "Install-ChocolateyPath" accidentally expands unrelated environment variables embedded in the path as well?

[ferventcoder]

@DarwinJS This is already a known issue and also already has a PR to fix it up. I've also added notes on how this would be fixed in the powershell function file related to install-chocolateypath.

[ferventcoder]

Let's continue discussion in the actual ticket over on Choco.

[ferventcoder]

chocolatey/choco#310