Skip to content

Commit

Permalink
Use forked version of cobra
Browse files Browse the repository at this point in the history
We use a forked version of cobra on
`github.com/chmouel/cobra@zsh-completion-fixes` which includes two patches that
hasn't been merged :

spf13/cobra#884
spf13/cobra#899

hopefully this won't needed when those issues gets merged.

Signed-off-by: Chmouel Boudjnah <[email protected]>
  • Loading branch information
chmouel committed Aug 20, 2019
1 parent c621535 commit 9fd194b
Show file tree
Hide file tree
Showing 11 changed files with 79 additions and 16 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ lint: ## run linter(s)
.PHONY: test-unit
test-unit: ./vendor ## run unit tests
@echo "Running unit tests..."
@go test -v -cover ./...
@go test -failfast -v -cover ./...

.PHONY: test-e2e
test-e2e: ./vendor ## run e2e tests
Expand Down
2 changes: 2 additions & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,5 @@ require (
)

replace github.com/kr/pty => github.com/creack/pty v1.1.7

replace github.com/spf13/cobra => github.com/chmouel/cobra v0.0.0-20190820110723-8f09bb39b20d
2 changes: 2 additions & 0 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ github.com/bradfitz/go-smtpd v0.0.0-20170404230938-deb6d6237625/go.mod h1:HYsPBT
github.com/census-instrumentation/opencensus-proto v0.0.2-0.20180913191712-f303ae3f8d6a/go.mod h1:f6KPmirojxKA12rnyqOA5BBL4O983OfeGPqjHWSTneU=
github.com/census-instrumentation/opencensus-proto v0.1.0 h1:VwZ9smxzX8u14/125wHIX7ARV+YhR+L4JADswwxWK0Y=
github.com/census-instrumentation/opencensus-proto v0.1.0/go.mod h1:f6KPmirojxKA12rnyqOA5BBL4O983OfeGPqjHWSTneU=
github.com/chmouel/cobra v0.0.0-20190820110723-8f09bb39b20d h1:rZ/9d/lEvSkKIdobXFmmz6qMqtfJVEaj5R6RLrKydRU=
github.com/chmouel/cobra v0.0.0-20190820110723-8f09bb39b20d/go.mod h1:3K3wKZymM7VvHMDS9+Akkh4K60UwM26emMESw8tLCHU=
github.com/client9/misspell v0.3.4/go.mod h1:qj6jICC3Q7zFZvVWo7KLAzC3yx5G7kyvSDkc90ppPyw=
github.com/coreos/etcd v3.3.10+incompatible/go.mod h1:uF7uidLiAD3TWHmW31ZFd/JWoc32PjwdhPthX9715RE=
github.com/coreos/go-etcd v2.0.0+incompatible/go.mod h1:Jez6KQU2B/sWsbdaef3ED8NzMklzPG4d5KIOhIy30Tk=
Expand Down
5 changes: 3 additions & 2 deletions vendor/github.com/spf13/cobra/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions vendor/github.com/spf13/cobra/README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 10 additions & 4 deletions vendor/github.com/spf13/cobra/bash_completions.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions vendor/github.com/spf13/cobra/cobra.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 18 additions & 4 deletions vendor/github.com/spf13/cobra/command.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions vendor/github.com/spf13/cobra/shell_completions.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

33 changes: 31 additions & 2 deletions vendor/github.com/spf13/cobra/zsh_completions.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion vendor/modules.txt
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ github.com/prometheus/procfs/xfs
github.com/prometheus/procfs/internal/util
# github.com/russross/blackfriday v1.5.2
github.com/russross/blackfriday
# github.com/spf13/cobra v0.0.5
# github.com/spf13/cobra v0.0.5 => github.com/chmouel/cobra v0.0.0-20190820110723-8f09bb39b20d
github.com/spf13/cobra
# github.com/spf13/pflag v1.0.3
github.com/spf13/pflag
Expand Down

0 comments on commit 9fd194b

Please sign in to comment.