Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERROR gosmee bufio.Scanner: token too long #77

Closed
portante opened this issue Apr 20, 2023 · 4 comments · Fixed by #84
Closed

ERROR gosmee bufio.Scanner: token too long #77

portante opened this issue Apr 20, 2023 · 4 comments · Fixed by #84

Comments

@portante
Copy link
Contributor

Saw the following error that killed the gosmee client process:

ERROR gosmee bufio.Scanner: token too long
@chmouel
Copy link
Owner

chmouel commented Apr 25, 2023

that's weird one! was there any way to reproduce it ?

@portante
Copy link
Contributor Author

I am not sure how to reproduce this problem yet. I'd be great to have logs from the gosmee server dump the X-GitHub-Delivery header and X-GitHub-Event header in the logs so that I can match it up with what GitHub posts, and then have the gosmee client dump those same headers when a message is received before it is parsed to see if it is related to the payload or not.

@portante
Copy link
Contributor Author

Okay, was able to reproduce it. It has to do with really large payloads. I made a commit with a huge commit message and I ran into that error.

@portante portante mentioned this issue Apr 25, 2023
Draft
@portante
Copy link
Contributor Author

I have referenced my test CI job that cause the problem here.

This was referenced Apr 27, 2023
Open
Open
portante added a commit to portante/gosmee that referenced this issue Apr 27, 2023
@portante
Use 1 MB buffers to avoid silent errors
94d1be1 
See r3labs/sse#158, "Improve receive message
error handling."

Fixes chmouel#77, "`ERROR gosmee
bufio.Scanner: token too long`".
@portante portante mentioned this issue Apr 27, 2023
Merged
portante added a commit to portante/gosmee that referenced this issue Apr 27, 2023
@portante
Use 1 MB buffers to avoid silent errors
79756fd 
See r3labs/sse#158, "Improve receive message
error handling."

Fixes chmouel#77, "`ERROR gosmee
bufio.Scanner: token too long`".
portante added a commit to portante/gosmee that referenced this issue Apr 27, 2023
@portante
Use 1 MB buffers to avoid silent errors
05f2478 
See r3labs/sse#158, "Improve receive message
error handling."

Fixes chmouel#77, "`ERROR gosmee
bufio.Scanner: token too long`".
portante added a commit to portante/gosmee that referenced this issue Apr 29, 2023
@portante
Use 1 MB buffers to avoid silent errors
dc14cd2 
See r3labs/sse#158, "Improve receive message
error handling."

Fixes chmouel#77, "`ERROR gosmee
bufio.Scanner: token too long`".
@chmouel chmouel closed this as completed in 5969d6b May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use 1 MB buffers to avoid silent errors portante/gosmee
2 participants
@chmouel @portante