Added support for CMake toolchain independent build framework #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The InitOnceExecuteOnce function doesn't exist on Windows XP/Server 2003. It is used to lazy initialise on first use. Whilst it is an elegant solution its benefit in leveldb is negligable. I've replace it with a Meyer's Singleton that is used to init the global at runtime rather than on first use. This loses the lazy initialisation but gains the benefit of working on all flavours of Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake will automatically generate the correct Visual Studio solution and project files for your installed compiler. It allows you to create the project in a toolchain agnostic manner. I can also be used to build on other platforms (such as Mac of Linux).
This change adds support for CMake, fixes an issue with ssize_t not being defined and removes the existing 2010 project file as it's no longer necessary.
I hope this change proves useful to the project.
Thanks.