Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Giscus Support #481

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Conversation

rterakedis
Copy link
Contributor

Adding support for https://giscus.app/ commenting. Comments and Reactions are added and tracked in GitHub discussions. This commenting system works similarly to Utterances.

Pull Request type

Please check the type of change your PR introduces:

  • Bug-fix
  • Feature (functionality, design, translations, etc.)
  • Documentation change
  • Project management (tests, CI, GitHub configuration, etc.)
  • Other (please describe):

Current state

Issue Number(s): No current issue requesting this

Proposed changes

Adding support for https://giscus.app/ commenting. Comments and Reactions are added and tracked in GitHub discussions. This commenting system works similarly to Utterances.

Giscus is loaded in the comments.html partial by referring to the giscus.html partial. Since single.html layout loads comments if comments are enabled, you must ensure both the comments and giscus parameters are configured in Site Params.

Screenshots, if applicable

image

Checklist

  • Bug-fixes and new features: I have tested locally with the latest release of Hugo extended. This requirement is a standard.
  • Bug-fixes, new features, and doc changes: I have updated the relevant documentation as part of this PR.
  • All PRs: I have signed off (using git commit -s ...), or if not possible due to developer environment constraints, will comment below confirming that I am adhering to the Developer Certificate of Origin.

Adding giscus.app support (similar to utterances)

Signed-off-by: Robert Terakedis <[email protected]>
README.md Outdated Show resolved Hide resolved
Copy link
Owner

@chipzoller chipzoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this one too. I have not tested Giscus before, have you tested these changes yourself?

@chipzoller chipzoller requested a review from onweru September 22, 2024 12:08
@chipzoller
Copy link
Owner

Please also sign off on your commits (DCO) so we can accept this.

@rterakedis
Copy link
Contributor Author

Hey @chipzoller - It looks like my commit was signed off:

image

Looking at the DCO check, it's actually your update to the readme that isn't signed off?

image

@rterakedis
Copy link
Contributor Author

Thanks for this one too. I have not tested Giscus before, have you tested these changes yourself?

✅ I have tested this personally in my own website. I switched from Utterances to Giscus awhile back and wanted to contribute the code back for others to use (and so I can stop using partial overrides). 😄

1 similar comment
@rterakedis
Copy link
Contributor Author

Thanks for this one too. I have not tested Giscus before, have you tested these changes yourself?

✅ I have tested this personally in my own website. I switched from Utterances to Giscus awhile back and wanted to contribute the code back for others to use (and so I can stop using partial overrides). 😄

@chipzoller chipzoller merged commit 174a5e6 into chipzoller:master Sep 23, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants