-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Giscus Support #481
Conversation
Adding giscus.app support (similar to utterances) Signed-off-by: Robert Terakedis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this one too. I have not tested Giscus before, have you tested these changes yourself?
Please also sign off on your commits (DCO) so we can accept this. |
Hey @chipzoller - It looks like my commit was signed off: Looking at the DCO check, it's actually your update to the readme that isn't signed off? |
✅ I have tested this personally in my own website. I switched from Utterances to Giscus awhile back and wanted to contribute the code back for others to use (and so I can stop using partial overrides). 😄 |
1 similar comment
✅ I have tested this personally in my own website. I switched from Utterances to Giscus awhile back and wanted to contribute the code back for others to use (and so I can stop using partial overrides). 😄 |
Adding support for https://giscus.app/ commenting. Comments and Reactions are added and tracked in GitHub discussions. This commenting system works similarly to Utterances.
Pull Request type
Please check the type of change your PR introduces:
Current state
Issue Number(s): No current issue requesting this
Proposed changes
Adding support for https://giscus.app/ commenting. Comments and Reactions are added and tracked in GitHub discussions. This commenting system works similarly to Utterances.
Giscus is loaded in the comments.html partial by referring to the giscus.html partial. Since single.html layout loads comments if comments are enabled, you must ensure both the comments and giscus parameters are configured in Site Params.
Screenshots, if applicable
Checklist
git commit -s ...
), or if not possible due to developer environment constraints, will comment below confirming that I am adhering to the Developer Certificate of Origin.