Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding giscus commenting support #467

Closed
wants to merge 2 commits into from
Closed

Adding giscus commenting support #467

wants to merge 2 commits into from

Conversation

rterakedis
Copy link
Contributor

Adding support for https://giscus.app commenting. Comments and Reactions are added and tracked in GitHub discussions. This commenting system works similarly to Utterances.

Pull Request type

Please check the type of change your PR introduces:

  • Bug-fix
  • Feature (functionality, design, translations, etc.)
  • Documentation change
  • Project management (tests, CI, GitHub configuration, etc.)
  • Other (please describe):

Current state

Issue Number(s): No Current Issue requesting this.

Proposed changes

Adding support for https://giscus.app commenting. Comments and Reactions are added and tracked in GitHub discussions. This commenting system works similarly to Utterances.

Giscus is loaded in the comments.html partial by referring to the giscus.html partial. Since single.html layout loads comments if comments are enabled, you must ensure both the comments and giscus parameters are configured in Site Params.

Screenshots, if applicable

image

Checklist

  • Bug-fixes and new features: I have tested locally with the latest release of Hugo extended. This requirement is a standard.
  • Bug-fixes, new features, and doc changes: I have updated the relevant documentation as part of this PR.
  • All PRs: I have signed off (using git commit -s ...), or if not possible due to developer environment constraints, will comment below confirming that I am adhering to the Developer Certificate of Origin.

Adding support for https://giscus.app commenting support.  Comments and Reactions are added and tracked in GitHub discussions.

Signed-off-by: Robert Terakedis <[email protected]>
@rterakedis
Copy link
Contributor Author

Noticed this PR contains more than the single relevant commit. CLosing and will resubmit.

@rterakedis rterakedis closed this Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant