Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure Caption Double Up #265

Closed
rianbk opened this issue Feb 19, 2022 · 6 comments
Closed

Figure Caption Double Up #265

rianbk opened this issue Feb 19, 2022 · 6 comments

Comments

@rianbk
Copy link

rianbk commented Feb 19, 2022

I have checked all the prerequisites below and I'm yet experiencing a problem

  • [Yes ] Read the README.md
  • [Yes] Have the extended version of Hugo installed
  • [Yes ] Used the exampleSite's config.toml as a reference
  • [No(private)] I have included my repository link. Instead of pasting long snippets here.

Describe the bug

Hi, I'm seem to be getting double figure captions after upgrading the theme (I was pretty far behind)
Example:
image

from
image

image

Live Post: https://rianbk.com/posts/2022-02-13-amazon-cloudfront-and-security-groups/

Desktop (please complete the following information):
OS: Win 11
Browser: Chrome

@rootwork
Copy link
Contributor

I'm noticing this too. I wonder if I missed something in #206. I'm going to take a look.

@rootwork
Copy link
Contributor

Oh, I think it was probably actually in the #219 follow-up.

onweru added a commit that referenced this issue Feb 22, 2022
@onweru
Copy link
Collaborator

onweru commented Feb 22, 2022

Thanks @rianbk for reporting this issue. It has now been fixed.

@rootwork, you almost caught it 😁. It was caused by the addition of these lines. And the double captioning occurred only if you specified the image title in the markdown.

Was quicker fixing it from the js script.

@chipzoller
Copy link
Owner

Awesome @onweru

@rootwork
Copy link
Contributor

Thanks for finding it @onweru :)

@rianbk
Copy link
Author

rianbk commented Feb 22, 2022

Hey all, thanks, can confirm this has resolved my issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants