Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhysicalFilter: add RegFieldDesc and scaladoc #2685

Merged
merged 4 commits into from
Nov 3, 2020
Merged

PhysicalFilter: add RegFieldDesc and scaladoc #2685

merged 4 commits into from
Nov 3, 2020

Conversation

mwachs5
Copy link
Contributor

@mwachs5 mwachs5 commented Oct 27, 2020

Related issue:

Type of change: other enhancement

Impact: API modification

Development Phase: implementation

Release Notes

Add RegFieldDesc and scaladoc to PhysicalFilter Tile Link Device

@mwachs5 mwachs5 requested review from hcook and terpstra October 27, 2020 05:10
hcook
hcook approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@hcook hcook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how the block actually works but the added messages and comments all look self-consistent.

@mwachs5 mwachs5 force-pushed the physical-filter-docs branch from 0184cf9 to b54f305 Compare November 3, 2020 04:12
@mwachs5 mwachs5 merged commit 4026144 into master Nov 3, 2020
@mwachs5 mwachs5 deleted the physical-filter-docs branch December 17, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcook hcook hcook approved these changes

@terpstra terpstra Awaiting requested review from terpstra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mwachs5 @hcook