Adding V2 Constructors in Paramaters and Emits Parameters #2532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brrmorre
commented
Jul 6, 2020
| TLMasterParameters.v2( | ||
| name = m.name, | ||
| nodePath = m.nodePath, | ||
| emits = TLMasterToSlaveTransferSizes( |
There was a problem hiding this comment.
Add a comment that specifies that "This value should be constrained by a data width parameter that flows from masters to slaves"
brrmorre
commented
Jul 6, 2020
| // Not a union, because the result may contain sizes contained by neither term | ||
| // NOT TO BE CONFUSED WITH COVERPOINTS | ||
| def cover(x: TransferSizes) = { |
There was a problem hiding this comment.
replace this with mincover
brrmorre
commented
Jul 6, 2020
| managerFn = { m => m.v1copy(managers = m.managers.map(mapManager)) }) | ||
| requestFifo = true, | ||
| emits = TLMasterToSlaveTransferSizes( | ||
| acquireT = c.masters.map(_.emits.acquireT) .reduce(_ cover _), |
There was a problem hiding this comment.
try and use shrinktransfer to make the bound tighter
terpstra
reviewed
Jul 6, 2020
| managerFn = { m => m.v1copy(managers = m.managers.map(mapManager)) }) | ||
| requestFifo = true, | ||
| emits = TLMasterToSlaveTransferSizes( | ||
| acquireT = c.masters.map(_.emits.acquireT) .reduce(_ cover _), |
There was a problem hiding this comment.
Maybe: = shrinkTransfer(c.masters.map(_.emits.acquireT) .reduce(_ cover _))
brrmorre
commented
Jul 6, 2020
| address: Seq[AddressSet], | ||
| nodePath: Seq[BaseNode] = Seq(), | ||
| resources: Seq[Resource] = Seq(), | ||
| setName: Option[String] = None, |
There was a problem hiding this comment.
try and change setname to name
brrmorre
changed the title
…ed function calls in monitors
…ed function calls in monitors
jchang0
approved these changes
Jul 17, 2020
|
Can you clarify from higher level what the v2 is? why it is even needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
Type of change: bug report | feature request | other enhancement
Impact: no functional change | API addition (no impact on existing code) | API modification
Development Phase: proposal | implementation
Release Notes